-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Searchfield: Listview-specific fixes for search close Button #5102
Searchfield: Listview-specific fixes for search close Button #5102
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - im not sure how you want to fix all these similar issues. But it could be a case where you want to do them all in one PR. Because one could break another ect...But do what makes sense thats just a thought.
I was looking at the "double border" issue and half expecting that to be fixed here but if its later thats fine. If you tackle that it seems like you can change this rule
.listview-search .searchfield-wrapper {
height: 38px;
}
@tmcconechy found that we can target the input to just be 100% between both themes so just tweaked the solution a tiny bit (and also good catch, thanks). |
…eps between sequence (didn't test fully locally yet -- had issues w fdescribe on PC)
…d (does not fix "bind" issue)
Iterated/rewrote one of the more-flakey e2e datagrid tests that was failing on this branch... and that was at least passing locally consistently. Hopefully it does not trigger other cases 🤞 |
Explain the details for making this change. What existing problem does the pull request solve?
Fixes listview-specific alignment issues
Related github/jira issue (required):
Related to #5090 #5074 but does not close these. Pushing as separate PR to isolate testing cases/code as there are many permutations of close button stylings.
Steps necessary to review your pull request (required):
5090-tabs-and-listview-searchfield-close-fix
-visit http://localhost:4000/components/swaplist/example-search.html and verify close button is aligned
Included in this Pull Request: