Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview - Accent colors - Default shows azure in color selector, and should alabaster be kept as an option? #8151

Closed
volante007 opened this issue Nov 7, 2023 · 1 comment · Fixed by #8322
Assignees
Labels
preview For preview release only type: bug 🐛 [2] Velocity rating (Fibonacci)

Comments

@volante007
Copy link

volante007 commented Nov 7, 2023

Describe the bug
This is related to the preview/dev build, using alabaster as default. These are the colors returned from Soho.theme.personalizationColors() in Light mode, which we use to build the color selector (dropdown is-swatch)

{
    "default": {
        "id": "default",
        "name": "Default",
        "backgroundColorClass": "primary-bg-color", <--- This seems to have wrong value
        "value": "#0066D4" <--- Should this be white?
    },
    "alabaster": {
        "id": "alabaster",
        "name": "Alabaster",
        "backgroundColorClass": "alabaster",
        "value": "#ffffff"
    },
  // ... rest of accent colors
}

image

primary-bg-color in effect on the option
image

To Reproduce
I couldn't find the dev build deployed, but should be reproducible in an example that uses the swatch dropdown.

Expected behavior
primary-bg-color should be white. And will alabaster still be kept as a personalization color? We could filter it out if we want to avoid duplicates (Default & Alabaster), with a fallback to default if alabaster has previously been selected, so more of a question.

Additional context
The default value itself works fine, i.e. headers/subheaders/tabs get alabaster. It's just the representation of it in the swatch.

Version

  • ids-enterprise: v4.89.0-dev.0

Platform

  • Infor Application/Team Name: OS Portal
@volante007 volante007 changed the title Preview - Accent colors - Default shows incorrect in color selector, and should alabaster be kept as an option? Preview - Accent colors - Default shows azure in color selector, and should alabaster be kept as an option? Nov 7, 2023
@tmcconechy tmcconechy added type: bug 🐛 [2] Velocity rating (Fibonacci) labels Nov 7, 2023
@tmcconechy tmcconechy self-assigned this Nov 7, 2023
@tmcconechy tmcconechy added the preview For preview release only label Nov 7, 2023
@tmcconechy
Copy link
Member

FYI a deployed version is here https://preview-enterprise.demo.design.infor.com/components
Will add a fix now for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview For preview release only type: bug 🐛 [2] Velocity rating (Fibonacci)
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants