Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc - Merge preview release with new icons and alabaster default #8322

Merged
merged 57 commits into from
Jan 12, 2024

Conversation

tmcconechy
Copy link
Member

Explain the details for making this change. What existing problem does the pull request solve?

Adding in the new icons and the change to make alabaster the default color on header controls. This can now be added and tested this month for roll out in Feb 4.82 release

Related github/jira issue (required):
Fixes #8152
Fixes #8151
Fixes #8129
Fixes #7861

Steps necessary to review your pull request (required):

All these were tested but should be tested once more for final inclusion, see history on the issues for more details

Included in this Pull Request:

  • A note to the change log.

@tmcconechy tmcconechy requested a review from a team as a code owner January 8, 2024 18:16
@ericangeles
Copy link
Contributor

Are we merging now the alabaster default to main, @tmcconechy ?

@tmcconechy
Copy link
Member Author

Yes we want new icons and alabaster as default now. For the 4.92 -> start of Feb. So ready to finally go in @ericangeles

@tmcconechy tmcconechy added the ready for qa Ready for QA to review label Jan 10, 2024
Copy link
Contributor

@janahintal janahintal left a comment

Copy link
Contributor

@glenlieorillo glenlieorillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some text and icons are not visible.
image

More button is not visible in Alabaster.
image

image

All icons are unavailable.
image

No logos are displayed.
image

@ericangeles
Copy link
Contributor

@tmcconechy, could we please merge this as soon as possible? I need the insights-smart-panel icon for the Gen AI tickets. Thank you!

@tmcconechy
Copy link
Member Author

@janahintal

  1. Not all icons are available in classic like the logos (this cant be fixed)
  2. Fixed

@glenlieorillo

Make sure to run npm prune && npm i on the localhost when testing or icons may be missing

  1. Fixed
  2. Could not reproduce try again (on localhost?)
  3. Could not reproduce try again (on localhost?)
  4. Could not reproduce on http://localhost:4000/components/icons/example-status-colors.html
  5. http://localhost:4000/components/icons/example-logos.html

@ericangeles sure just need to get this approved/tested then its done. Not delaying anymore than that. hopefully this should be it

glenlieorillo
glenlieorillo previously approved these changes Jan 12, 2024
Copy link
Contributor

@glenlieorillo glenlieorillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is now working as expected. Thanks, @tmcconechy!

image image image image
Screen.Recording.2024-01-12.at.3.59.27.PM.mov
Screen.Recording.2024-01-12.at.3.58.59.PM.mov
Screen.Recording.2024-01-12.at.3.59.49.PM.mov
image
Screen.Recording.2024-01-12.at.4.02.04.PM.mov
image image image image image image image image

jbrcna
jbrcna previously approved these changes Jan 12, 2024
@tmcconechy tmcconechy dismissed stale reviews from jbrcna and glenlieorillo via 7676310 January 12, 2024 15:14
@tmcconechy tmcconechy merged commit 0d6048b into main Jan 12, 2024
2 checks passed
@tmcconechy tmcconechy deleted the merge-preview branch January 12, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high ready for qa Ready for QA to review
Projects
None yet
7 participants