Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8151 - Added personalization color changes #8153

Merged
merged 4 commits into from
Nov 13, 2023

Conversation

tmcconechy
Copy link
Member

@tmcconechy tmcconechy commented Nov 7, 2023

Explain the details for making this change. What existing problem does the pull request solve?

Fixes some wrong colors in personalization.

Related github/jira issue (required):
Fixes #8151
Fixes #8152

Steps necessary to review your pull request (required):

Soho.theme.personalizationColors().default

Screenshot 2023-11-07 at 11 59 57 AM

Included in this Pull Request:

  • A note to the change log.

@tmcconechy tmcconechy requested a review from a team as a code owner November 7, 2023 17:34
@tmcconechy tmcconechy changed the title Added personalization color changes 8151 - Added personalization color changes Nov 7, 2023
@tmcconechy tmcconechy added the ready for qa Ready for QA to review label Nov 9, 2023
Copy link
Contributor

@glenlieorillo glenlieorillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix has already been applied. However, the 'More' menu is not visible.

Screen.Recording.2023-11-10.at.8.56.36.PM.mov
image

@tmcconechy
Copy link
Member Author

@glenlieorillo try running npm i because there is new icon packages and maybe you switched between a branch with old and new ones on localhost.

@jbrcna
Copy link
Contributor

jbrcna commented Nov 10, 2023

image

Copy link
Contributor

@janahintal janahintal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tmcconechy tmcconechy merged commit aaeee47 into preview Nov 13, 2023
2 checks passed
@tmcconechy tmcconechy deleted the 8151-personalization-colors branch November 13, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for qa Ready for QA to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants