-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3007 - Added new uplift colors #3298
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto 3007-new-uplift-colors
…nto 3007-new-uplift-colors
@elizabethhartley - please let me know if you have any comments |
…nto 3007-new-uplift-colors
@EdwardCoyle I fixed all the points you noted. I didnt actually see point two of it changing black text. I suspect when i adjusted the colors on point 1 i fixed it? If not let me know |
EdwardCoyle
previously approved these changes
Jan 7, 2020
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the details for making this change. What existing problem does the pull request solve?
Updated design system tokens to new colors for uplift and did a pass on all three theme variants. This impacts and improves many internal colors in components and charts. Also updated the look and feel of the colors page.
Related github/jira issue (required):
Fixes #3007
Steps necessary to review your pull request (required):
npm i
for new tokensKitchen Sink https://3007-new-uplift-colors-enterprise.demo.design.infor.com/?theme=uplift&variant=light
- Not much difference in tertiary hover state so made some changes
- Not sure about some disabled buttons, made some minor adjustments
- Do the “muted” labels look ok?
- Check readonly/disabled states and borders and placeholders?
Included in this Pull Request: