Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3007 - Added new uplift colors #3298

Merged
merged 13 commits into from
Jan 8, 2020
Merged

3007 - Added new uplift colors #3298

merged 13 commits into from
Jan 8, 2020

Conversation

tmcconechy
Copy link
Member

@tmcconechy tmcconechy commented Jan 6, 2020

Explain the details for making this change. What existing problem does the pull request solve?

Updated design system tokens to new colors for uplift and did a pass on all three theme variants. This impacts and improves many internal colors in components and charts. Also updated the look and feel of the colors page.

Related github/jira issue (required):
Fixes #3007

Steps necessary to review your pull request (required):

Included in this Pull Request:

  • An e2e or functional test for the bug or feature.
  • A note to the change log.

@tmcconechy tmcconechy requested a review from a team as a code owner January 6, 2020 19:38
@tmcconechy
Copy link
Member Author

@elizabethhartley - please let me know if you have any comments

@EdwardCoyle
Copy link
Contributor

EdwardCoyle commented Jan 7, 2020

Here's some things I found when reviewing:

Header/Theme Switcher - doesn’t always set the colors correctly:

  • header colors on Uplift “default” are different from Uplift “azure”
    Screen Shot 2020-01-07 at 9 42 30 AM
    Screen Shot 2020-01-07 at 9 42 45 AM

  • Some font colors set to black against headers where it should probably be white (I specifically noticed this on Turquoise and Amber):
    Screen Shot 2020-01-07 at 9 43 12 AM

Autocomplete (Dark)

  • “highlight” color (seen when hovering/selecting with keyboard) is pretty close to the background color
    Screen Shot 2020-01-07 at 10 14 07 AM

Datepicker

  • Modal Button focus states inside the picker are differently-sized (the submit button pops out, but the clear button doesn’t)

  • Regarding your note about WIP: it actually doesn't look bad to me.
    Screen Shot 2020-01-07 at 9 53 28 AM
    Screen Shot 2020-01-07 at 9 53 36 AM

  • I believe the Datepicker configured with a legend is using Soho colors against the Uplift theme, or they are just hardcoded to one color palette (specifically I noticed the emerald and azure don't match up):
    Screen Shot 2020-01-07 at 10 14 46 AM

Editor

  • Did the design for the popupmenus switch back to the standard design with an arrow? If not, this branch might need an update from 4.24.x
    Screen Shot 2020-01-07 at 10 16 41 AM

Input fields

  • opinion: I actually like the muted colors for the labels a lot more than what we previously had.

Sparkline Chart

  • there's something funky about one of the sparklines on this sample when using the Dark/Contrast variants:
    Screen Shot 2020-01-07 at 10 09 16 AM
    Screen Shot 2020-01-07 at 10 10 08 AM

@tmcconechy
Copy link
Member Author

@EdwardCoyle I fixed all the points you noted. I didnt actually see point two of it changing black text. I suspect when i adjusted the colors on point 1 i fixed it? If not let me know

EdwardCoyle
EdwardCoyle previously approved these changes Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uplift: Re-specify Qualitative colors for uplift.
2 participants