Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3400 - Vibrant theme App Menu colors Q/A [v4.25.x] #3401

Merged
merged 3 commits into from
Jan 28, 2020

Conversation

EdwardCoyle
Copy link
Contributor

Explain the details for making this change. What existing problem does the pull request solve?
This PR improves the color contrast between font and background colors in the Application Menu in the Vibrant theme. Previous changes from #3298 and #3356 modified token colors, which inadvertently lowered the amount of contrast between font and background colors on all variants of the Vibrant theme.

Related github/jira issue (required):
Closes #3400

Steps necessary to review your pull request (required):

Included in this Pull Request:

  • A note to the change log.

@EdwardCoyle EdwardCoyle requested review from vonnyw and a team January 28, 2020 19:26
@tmcconechy tmcconechy merged commit a84d0b5 into 4.25.x Jan 28, 2020
@tmcconechy tmcconechy deleted the 3400-vibrant-appmenu-color-qa branch January 28, 2020 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants