Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4261 - Add new fix for entering edit mode in dropdown [v4.31.x] #4263

Merged
merged 2 commits into from
Aug 17, 2020

Conversation

tmcconechy
Copy link
Member

Explain the details for making this change. What existing problem does the pull request solve?

Updated the fix on #3980 to solve #4261 by..

  • making it happen with no timeout
  • checking and ignoring certain keys
  • calling api same way

Related github/jira issue (required):
Fixes #4261

Steps necessary to review your pull request (required):

  • go to http://localhost:4000/components/datagrid/example-editable.html
  • click in the grid and arrow to the Action field
  • type a key like a or b and the dropdown should open and filter
  • reset
  • click in the grid and arrow to the Action field hit enter -> this will enter edit mode but wont open
  • now type a and it should filter
  • reset
  • click in the grid and hit F2 to toggle "tabs mode"
  • tab to the Action field -> this will enter edit mode but wont open
  • now type a and it should filter
  • try various tests of tabbing and arrowing and typing see if you can bust it

@EdwardCoyle EdwardCoyle merged commit 5e6106d into 4.31.x Aug 17, 2020
@EdwardCoyle EdwardCoyle deleted the 4261-dg-dropdownbug branch August 17, 2020 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants