Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1672 - Fix errors editing on second page #8605

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Conversation

tmcconechy
Copy link
Member

Explain the details for making this change. What existing problem does the pull request solve?

Fixed a bug editing on the second page in server side paging. This was caused by #7577

Related github/jira issue (required):
Fixes infor-design/enterprise-ng#1672

Steps necessary to review your pull request (required):

Included in this Pull Request:

  • A note to the change log.

@tmcconechy tmcconechy requested a review from a team as a code owner April 5, 2024 15:20
@tmcconechy tmcconechy added type: patch ready for qa Ready for QA to review labels Apr 5, 2024
n-ace-ancog
n-ace-ancog previously approved these changes Apr 8, 2024
Copy link

@n-ace-ancog n-ace-ancog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating rows no errors encountered
@tmcconechy - are we expecting changed values to persist when going to other pages?

Animation

Previous issue
Animation

Copy link
Contributor

@janahintal janahintal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericangeles
Copy link
Contributor

@janahintal, the error in your video does not seem to be related to our library. Also, I have tested it and I don't see any errors.

Copy link
Contributor

@jbrcna jbrcna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@tmcconechy
Copy link
Member Author

@n-ace-ancog no the value does not persist in server side examples. (We dont have a place to save it so when the data reloads per page its replaced) but it is saving it as to what we need, its an example issue.

Since this is approved an the error from @janahintal seems to come from some other web plugin. Will merge and patch

@tmcconechy tmcconechy merged commit 8ecd89f into main Apr 8, 2024
2 checks passed
@tmcconechy tmcconechy deleted the 1672-editing-error branch April 8, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for qa Ready for QA to review type: patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Datagrid: Server Paging - Cell editor is only working on First page but not Other pages.
5 participants