Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1672 - Fix errors editing on second page #8605

Merged
merged 2 commits into from
Apr 8, 2024
Merged

1672 - Fix errors editing on second page #8605

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a77aae
Fix errors editing on second page
tmcconechy Apr 5, 2024
33bf53e
Merge branch 'main' into 1672-editing-error
ericangeles Apr 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@

## v4.95.0 Fixes

- `[Datagrid]` Fixed an error editing on non first page in server side paging datagrid. ([#8537](https://github.com/infor-design/enterprise-ng/issues/1672))
- `[Forms]` Fixed fileupload layout in compact form. ([#8537](https://github.com/infor-design/enterprise/issues/8537))

## v4.94.0
Expand Down
2 changes: 1 addition & 1 deletion src/components/datagrid/datagrid.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11468,7 +11468,7 @@ Datagrid.prototype = {
dataRowIndex = row;
}

if (!isTreeGrid && this.settings.paging && this.pagerAPI.activePage > 1) {
if (!isTreeGrid && this.settings.paging && this.pagerAPI.activePage > 1 && !this.settings.source) {
if (dataRowIndex < (this.pagerAPI.activePage - 1) * this.settings.pagesize) {
dataRowIndex += (this.pagerAPI.activePage - 1) * this.settings.pagesize;
}
Expand Down
Loading