-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8870 - Datagrid Inline Editor SelectOnEdit #8919
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working on my end.
Screen.Recording.2024-07-25.at.7.07.39.PM.mov
@rcoseng can you test this? I was thinking that selectOnEdit would focus all the text when you click in. Was this the idea? I think the behavior is correct now but maybe we need this to be the default a selectOnEdit selects all the text. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I think this is a good way to provide options.
Can you add this to NG as well, @tjamesallen15 ?
@tmcconechy Hi, yes that is the idea. selectOnEdit = true would focus all the text. I have also tested it and it looks good. Thanks! |
Explain the details for making this change. What existing problem does the pull request solve?
This pull request will fix selecting issue on inline editor by adding
selectOnEdit
setting.Related github/jira issue (required):
Closes #8870
Steps necessary to review your pull request (required):
Included in this Pull Request: