Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8870 - Datagrid Inline Editor SelectOnEdit #8919

Merged
merged 3 commits into from
Jul 29, 2024

Conversation

tjamesallen15
Copy link
Contributor

Explain the details for making this change. What existing problem does the pull request solve?

This pull request will fix selecting issue on inline editor by adding selectOnEdit setting.

Related github/jira issue (required):
Closes #8870

Steps necessary to review your pull request (required):

Included in this Pull Request:

  • An e2e or functional test for the bug or feature.
  • A note to the change log.

@tjamesallen15 tjamesallen15 marked this pull request as ready for review July 25, 2024 05:03
@tjamesallen15 tjamesallen15 requested a review from a team as a code owner July 25, 2024 05:03
jbrcna
jbrcna previously approved these changes Jul 25, 2024
Copy link
Contributor

@jbrcna jbrcna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

n-ace-ancog
n-ace-ancog previously approved these changes Jul 25, 2024
Copy link

@n-ace-ancog n-ace-ancog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working on my end.

Screen.Recording.2024-07-25.at.7.07.39.PM.mov

@tmcconechy tmcconechy dismissed stale reviews from n-ace-ancog and jbrcna via f639dd5 July 25, 2024 12:27
@tmcconechy
Copy link
Member

@rcoseng can you test this?

I was thinking that selectOnEdit would focus all the text when you click in. Was this the idea? I think the behavior is correct now but maybe we need this to be the default a selectOnEdit selects all the text.

Copy link
Contributor

@ericangeles ericangeles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think this is a good way to provide options.

Can you add this to NG as well, @tjamesallen15 ?

@tmcconechy tmcconechy merged commit ab2ce23 into main Jul 29, 2024
4 checks passed
@tmcconechy tmcconechy deleted the 8870-datagrid-inline-select-edit branch July 29, 2024 13:43
@rcoseng
Copy link

rcoseng commented Aug 1, 2024

@rcoseng can you test this?

I was thinking that selectOnEdit would focus all the text when you click in. Was this the idea? I think the behavior is correct now but maybe we need this to be the default a selectOnEdit selects all the text.

@tmcconechy Hi, yes that is the idea. selectOnEdit = true would focus all the text. I have also tested it and it looks good. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Datagrid: Add selectOnEdit setting for inline editor
6 participants