-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make example trace output optional via --save-runs
#2047
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was outputting the same trace twice on the last symblic run with `simulate`.
Kukovec
reviewed
Aug 8, 2022
mod-tool/src/main/scala/at/forsyte/apalache/tla/tooling/opt/CheckCmd.scala
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## main #2047 +/- ##
==========================================
- Coverage 77.73% 77.72% -0.01%
==========================================
Files 420 420
Lines 12847 12846 -1
Branches 577 588 +11
==========================================
- Hits 9986 9985 -1
Misses 2861 2861
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Kukovec
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduced example trace output in #1838. As described in #2039 and #2019, this creates a unexpected performance bottleneck if the SMT call for constructing the trace takes a long time.
Oddly enough, writing the trace was made optional for
simulate
via the--save-runs
flag (defaulting tofalse
) in #1838, but always enabled forcheck
.With this PR, we lift
--save-runs
tocheck
, making example trace output optional also forcheck
.We also make some UX improvements that
simulate
was output twice,ERROR
toINFO
.Tests added for any new codemake fmt-fix
(or had formatting run automatically on all files edited)Documentation added for any new functionality./unreleased/
for any new functionalityFixes #2039