Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip consensus_heights query in update_client when possible #1379

Merged
merged 5 commits into from
Sep 22, 2021

Conversation

soareschen
Copy link
Contributor

@soareschen soareschen commented Sep 22, 2021

Closes: #1362

Description


For contributor use:

  • Added a changelog entry, using unclog.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

Copy link
Collaborator

@ancazamfir ancazamfir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @soareschen!

relayer/src/foreign_client.rs Outdated Show resolved Hide resolved
Copy link
Member

@adizere adizere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go team!

@soareschen
Copy link
Contributor Author

Go team!

s/Go/Rust/

@adizere adizere merged commit b964bac into master Sep 22, 2021
@adizere adizere deleted the soares/optimize-update-client branch September 22, 2021 13:11
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
…rmalsystems#1379)

* Skip consensus_heights query in update_client when possible

* Add some comments

* warning

* Fix crate::time! tags

* Fix indentation

Co-authored-by: Adi Seredinschi <adi@informal.systems>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hermes operational data processing time
3 participants