Replace signatory with ed25519-dalek and k256 crates

Native support for the `signature` traits used by the `signatory*`
was recently added to `ed25519-dalek` in v1.0.0-pre.4, and the `k256`
crate recently added a native pure Rust implementation of
ECDSA/secp256k1.

Together these changes eliminate the need for the `signatory*` wrapper
crates. Additionally, `k256` eliminates the need for the rust-secp256k1
C-based library, which has been problematic with e.g. WASM (#391).

This commit eliminates all `signatory` dependencies and uses
`ed25519-dalek` and `k256` directly instead. Both of these were already
dependencies, so it's not adding any additional dependencies, but
instead removes several of them.

light-client/src/operations/voting_power.rs

@@ -146,9 +146,12 @@ impl VotingPowerCalculator for ProdVotingPowerCalculator {
 
             // Check vote is valid
             let sign_bytes = signed_vote.sign_bytes();
-            if !validator.verify_signature(&sign_bytes, signed_vote.signature()) {
+            if validator
+                .verify_signature(&sign_bytes, signed_vote.signature())
+                .is_err()
+            {
                 bail!(VerificationError::InvalidSignature {
-                    signature: signed_vote.signature().to_vec(),
+                    signature: signed_vote.signature().to_bytes(),
                     validator,
                     sign_bytes,
                 });
@@ -186,14 +189,14 @@ fn non_absent_vote(commit_sig: &CommitSig, validator_index: u64, commit: &Commit
         } => (
             *validator_address,
             *timestamp,
-            signature.clone(),
+            signature,
             Some(commit.block_id.clone()),
         ),
         CommitSig::BlockIDFlagNil {
             validator_address,
             timestamp,
             signature,
-        } => (*validator_address, *timestamp, signature.clone(), None),
+        } => (*validator_address, *timestamp, signature, None),
     };
 
     Some(Vote {
@@ -204,7 +207,7 @@ fn non_absent_vote(commit_sig: &CommitSig, validator_index: u64, commit: &Commit
         timestamp,
         validator_address,
         validator_index,
-        signature,
+        signature: *signature,
     })
 }
 

tendermint/Cargo.toml

@@ -27,16 +27,17 @@ authors = [
 
 [package.metadata.docs.rs]
 all-features = true
-
-[badges]
-codecov = { repository = "..."}
+rustdoc-args = ["--cfg", "docsrs"]
 
 [dependencies]
 anomaly = "0.2"
 async-trait = "0.1"
 bytes = "0.5"
 chrono = { version = "0.4", features = ["serde"] }
+ed25519 = "1"
+ed25519-dalek = { version = "= 1.0.0-pre.4", features = ["serde"] }
 futures = "0.3"
+k256 = { version = "0.4", optional = true, features = ["ecdsa"] }
 once_cell = "1.3"
 prost-amino = "0.6"
 prost-amino-derive = "0.6"
@@ -45,9 +46,7 @@ serde_json = "1"
 serde_bytes = "0.11"
 serde_repr = "0.1"
 sha2 = { version = "0.9", default-features = false }
-signatory = { version = "0.20", features = ["ed25519", "ecdsa"] }
-signatory-dalek = "0.20"
-signatory-secp256k1 = { version = "0.20", optional = true }
+signature = "1.2"
 subtle = "2"
 subtle-encoding = { version = "0.5", features = ["bech32-preview"] }
 tai64 = { version = "3", features = ["chrono"] }
@@ -61,4 +60,4 @@ tendermint-rpc = { path = "../rpc", features = [ "client" ] }
 tokio = { version = "0.2", features = [ "macros" ] }
 
 [features]
-secp256k1 = ["signatory-secp256k1", "ripemd160"]
+secp256k1 = ["k256", "ripemd160"]

tendermint/src/account.rs

@@ -1,20 +1,25 @@
 //! Tendermint accounts
 
-use crate::error::{Error, Kind};
-#[cfg(feature = "secp256k1")]
-use ripemd160::Ripemd160;
+use crate::{
+    error::{Error, Kind},
+    public_key::Ed25519,
+};
+
 use serde::{de, Deserialize, Deserializer, Serialize, Serializer};
 use sha2::{Digest, Sha256};
-#[cfg(feature = "secp256k1")]
-use signatory::ecdsa::curve::secp256k1;
-use signatory::ed25519;
 use std::{
+    convert::TryInto,
     fmt::{self, Debug, Display},
     str::FromStr,
 };
 use subtle::{self, ConstantTimeEq};
 use subtle_encoding::hex;
 
+#[cfg(feature = "secp256k1")]
+use crate::public_key::Secp256k1;
+#[cfg(feature = "secp256k1")]
+use ripemd160::Ripemd160;
+
 /// Size of an  account ID in bytes
 pub const LENGTH: usize = 20;
 
@@ -64,8 +69,8 @@ impl Debug for Id {
 
 // RIPEMD160(SHA256(pk))
 #[cfg(feature = "secp256k1")]
-impl From<secp256k1::PublicKey> for Id {
-    fn from(pk: secp256k1::PublicKey) -> Id {
+impl From<Secp256k1> for Id {
+    fn from(pk: Secp256k1) -> Id {
         let sha_digest = Sha256::digest(pk.as_bytes());
         let ripemd_digest = Ripemd160::digest(&sha_digest[..]);
         let mut bytes = [0u8; LENGTH];
@@ -75,12 +80,10 @@ impl From<secp256k1::PublicKey> for Id {
 }
 
 // SHA256(pk)[:20]
-impl From<ed25519::PublicKey> for Id {
-    fn from(pk: ed25519::PublicKey) -> Id {
+impl From<Ed25519> for Id {
+    fn from(pk: Ed25519) -> Id {
         let digest = Sha256::digest(pk.as_bytes());
-        let mut bytes = [0u8; LENGTH];
-        bytes.copy_from_slice(&digest[..LENGTH]);
-        Id(bytes)
+        Id(digest[..LENGTH].try_into().unwrap())
     }
 }
 
@@ -141,7 +144,7 @@ mod tests {
         let id_bytes = Id::from_str(id_hex).expect("expected id_hex to decode properly");
 
         // get id for pubkey
-        let pubkey = ed25519::PublicKey::from_bytes(pubkey_bytes).unwrap();
+        let pubkey = Ed25519::from_bytes(pubkey_bytes).unwrap();
         let id = Id::from(pubkey);
 
         assert_eq!(id_bytes.ct_eq(&id).unwrap_u8(), 1);
@@ -160,7 +163,7 @@ mod tests {
         let id_bytes = Id::from_str(id_hex).expect("expected id_hex to decode properly");
 
         // get id for pubkey
-        let pubkey = secp256k1::PublicKey::from_bytes(pubkey_bytes).unwrap();
+        let pubkey = Secp256k1::from_bytes(pubkey_bytes).unwrap();
         let id = Id::from(pubkey);
 
         assert_eq!(id_bytes.ct_eq(&id).unwrap_u8(), 1);

tendermint/src/amino_types/ed25519.rs

@@ -1,8 +1,13 @@
 use super::compute_prefix;
-use crate::public_key::PublicKey;
+use crate::{
+    error,
+    public_key::{Ed25519, PublicKey},
+    Error,
+};
+use anomaly::format_err;
 use once_cell::sync::Lazy;
 use prost_amino_derive::Message;
-use signatory::ed25519::PUBLIC_KEY_SIZE;
+use std::convert::TryFrom;
 
 // Note:On the golang side this is generic in the sense that it could everything that implements
 // github.com/tendermint/tendermint/crypto.PubKey
@@ -24,13 +29,15 @@ pub struct PubKeyResponse {
 #[amino_name = "tendermint/remotesigner/PubKeyRequest"]
 pub struct PubKeyRequest {}
 
-impl From<PubKeyResponse> for PublicKey {
+impl TryFrom<PubKeyResponse> for PublicKey {
+    type Error = Error;
+
     // This does not check if the underlying pub_key_ed25519 has the right size.
     // The caller needs to make sure that this is actually the case.
-    fn from(response: PubKeyResponse) -> PublicKey {
-        let mut public_key = [0u8; PUBLIC_KEY_SIZE];
-        public_key.copy_from_slice(response.pub_key_ed25519.as_ref());
-        PublicKey::Ed25519(signatory::ed25519::PublicKey::new(public_key))
+    fn try_from(response: PubKeyResponse) -> Result<PublicKey, Error> {
+        Ed25519::from_bytes(&response.pub_key_ed25519)
+            .map(Into::into)
+            .map_err(|_| format_err!(error::Kind::InvalidKey, "malformed Ed25519 key").into())
     }
 }
 
@@ -49,7 +56,9 @@ impl From<PublicKey> for PubKeyResponse {
 #[cfg(test)]
 mod tests {
     use super::*;
+    use ed25519_dalek::PUBLIC_KEY_LENGTH;
     use prost_amino::Message;
+    use std::convert::TryInto;
 
     #[test]
     fn test_empty_pubkey_msg() {
@@ -140,21 +149,21 @@ mod tests {
 
     #[test]
     fn test_into() {
-        let raw_pk: [u8; PUBLIC_KEY_SIZE] = [
-            0x79, 0xce, 0xd, 0xe0, 0x43, 0x33, 0x4a, 0xec, 0xe0, 0x8b, 0x7b, 0xb5, 0x61, 0xbc,
-            0xe7, 0xc1, 0xd4, 0x69, 0xc3, 0x44, 0x26, 0xec, 0xef, 0xc0, 0x72, 0xa, 0x52, 0x4d,
-            0x37, 0x32, 0xef, 0xed,
+        let raw_pk: [u8; PUBLIC_KEY_LENGTH] = [
+            0xaf, 0xf3, 0x94, 0xc5, 0xb7, 0x5c, 0xfb, 0xd, 0xd9, 0x28, 0xe5, 0x8a, 0x92, 0xdd,
+            0x76, 0x55, 0x2b, 0x2e, 0x8d, 0x19, 0x6f, 0xe9, 0x12, 0x14, 0x50, 0x80, 0x6b, 0xd0,
+            0xd9, 0x3f, 0xd0, 0xcb,
         ];
-        let want = PublicKey::Ed25519(signatory::ed25519::PublicKey::new(raw_pk));
+        let want = PublicKey::Ed25519(Ed25519::from_bytes(&raw_pk).unwrap());
         let pk = PubKeyResponse {
             pub_key_ed25519: vec![
-                0x79, 0xce, 0xd, 0xe0, 0x43, 0x33, 0x4a, 0xec, 0xe0, 0x8b, 0x7b, 0xb5, 0x61, 0xbc,
-                0xe7, 0xc1, 0xd4, 0x69, 0xc3, 0x44, 0x26, 0xec, 0xef, 0xc0, 0x72, 0xa, 0x52, 0x4d,
-                0x37, 0x32, 0xef, 0xed,
+                0xaf, 0xf3, 0x94, 0xc5, 0xb7, 0x5c, 0xfb, 0xd, 0xd9, 0x28, 0xe5, 0x8a, 0x92, 0xdd,
+                0x76, 0x55, 0x2b, 0x2e, 0x8d, 0x19, 0x6f, 0xe9, 0x12, 0x14, 0x50, 0x80, 0x6b, 0xd0,
+                0xd9, 0x3f, 0xd0, 0xcb,
             ],
         };
         let orig = pk.clone();
-        let got: PublicKey = pk.into();
+        let got: PublicKey = pk.try_into().unwrap();
 
         assert_eq!(got, want);
 
@@ -170,6 +179,6 @@ mod tests {
             pub_key_ed25519: vec![],
         };
         // we expect this to panic:
-        let _got: PublicKey = empty_msg.into();
+        let _got: PublicKey = empty_msg.try_into().unwrap();
     }
 }

tendermint/src/amino_types/proposal.rs

@@ -17,7 +17,6 @@ use bytes::BufMut;
 use once_cell::sync::Lazy;
 use prost_amino::{EncodeError, Message};
 use prost_amino_derive::Message;
-use signatory::ed25519;
 use std::convert::TryFrom;
 
 #[derive(Clone, PartialEq, Message)]

tendermint/src/amino_types/signature.rs

@@ -2,7 +2,6 @@ use super::validate;
 use crate::{chain, consensus};
 use bytes::BufMut;
 use prost_amino::{DecodeError, EncodeError};
-use signatory::ed25519;
 
 /// Amino messages which are signable within a Tendermint network
 pub trait SignableMsg {

tendermint/src/amino_types/vote.rs

@@ -19,7 +19,6 @@ use bytes::BufMut;
 use once_cell::sync::Lazy;
 use prost_amino::{error::EncodeError, Message};
 use prost_amino_derive::Message;
-use signatory::ed25519;
 use std::convert::TryFrom;
 
 const VALIDATOR_ADDR_SIZE: usize = 20;

tendermint/src/config/node_key.rs

@@ -2,9 +2,10 @@
 
 use crate::{
     error::{Error, Kind},
+    node,
     private_key::PrivateKey,
+    public_key::PublicKey,
 };
-use crate::{node, public_key::PublicKey};
 use anomaly::format_err;
 use serde::{Deserialize, Serialize};
 use std::{fs, path::Path};
@@ -42,15 +43,15 @@ impl NodeKey {
     /// Get the public key for this keypair
     pub fn public_key(&self) -> PublicKey {
         match &self.priv_key {
-            PrivateKey::Ed25519(key) => key.public_key(),
+            PrivateKey::Ed25519(keypair) => keypair.public.into(),
         }
     }
 
     /// Get node ID for this keypair
     pub fn node_id(&self) -> node::Id {
         #[allow(unreachable_patterns)]
         match &self.public_key() {
-            PublicKey::Ed25519(key) => node::Id::from(*key),
+            PublicKey::Ed25519(pubkey) => node::Id::from(*pubkey),
             _ => unreachable!(),
         }
     }

tendermint/src/lib.rs

@@ -4,6 +4,7 @@
 //! blockchain networks, including chain information types, secret connections,
 //! and remote procedure calls (JSONRPC).
 
+#![cfg_attr(docsrs, feature(doc_cfg))]
 #![deny(
     warnings,
     missing_docs,
@@ -50,17 +51,17 @@ pub mod vote;
 #[cfg(test)]
 mod test;
 
-pub use crate::genesis::Genesis;
 pub use crate::{
     block::Block,
     error::{Error, Kind},
+    genesis::Genesis,
     hash::Hash,
     moniker::Moniker,
+    private_key::PrivateKey,
     public_key::{PublicKey, TendermintKey},
     signature::Signature,
     time::Time,
     timeout::Timeout,
     version::Version,
     vote::Vote,
 };
-pub use private_key::PrivateKey;

tendermint/src/node/id.rs

@@ -1,9 +1,12 @@
 //! Tendermint node IDs
 
-use crate::error::{Error, Kind};
+use crate::{
+    error::{Error, Kind},
+    public_key::Ed25519,
+};
+
 use serde::{de, Deserialize, Deserializer, Serialize, Serializer};
 use sha2::{Digest, Sha256};
-use signatory::ed25519;
 use std::{
     fmt::{self, Debug, Display},
     str::FromStr,
@@ -58,8 +61,8 @@ impl Debug for Id {
     }
 }
 
-impl From<ed25519::PublicKey> for Id {
-    fn from(pk: ed25519::PublicKey) -> Id {
+impl From<Ed25519> for Id {
+    fn from(pk: Ed25519) -> Id {
         let digest = Sha256::digest(pk.as_bytes());
         let mut bytes = [0u8; LENGTH];
         bytes.copy_from_slice(&digest[..LENGTH]);