Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validators are now sorted by voting power instead of by address #506

Closed
greg-szabo opened this issue Aug 4, 2020 · 1 comment · Fixed by #565
Closed

Validators are now sorted by voting power instead of by address #506

greg-szabo opened this issue Aug 4, 2020 · 1 comment · Fixed by #565
Assignees
@greg-szabo
Labels
go Compatibility with Go code
Milestone
v0.17.0

Comments

@greg-szabo
Copy link
Member

This is a Tendermint-Go 0.34 compatibility upgrade issue brought by a comment in #305 by Ethan.
@xla xla added the go Compatibility with Go code label Aug 4, 2020
greg-szabo added a commit that referenced this issue Aug 26, 2020
@greg-szabo
As close as test_validator_set gets without issue #506
0780c16
@greg-szabo greg-szabo mentioned this issue Aug 26, 2020
Merged
5 tasks
@ebuchman ebuchman mentioned this issue Aug 28, 2020
Closed
greg-szabo added a commit that referenced this issue Sep 3, 2020
@greg-szabo
Ripped out amino types and replaced them with protobuf types.
192747a 
Domain types for protobuf structs (#537)

* Domain types
* DomainType derive macro
* DomainType added to all amino_types

As close as test_validator_set gets without issue #506
greg-szabo added a commit that referenced this issue Sep 3, 2020
@greg-szabo
As close as test_validator_set gets without issue #506
ffd3ed8
@greg-szabo greg-szabo self-assigned this Sep 8, 2020
@greg-szabo
Copy link
Member Author

I'm going to work on this now. I'm basing it on top of #537 which is not merged yet.

@greg-szabo greg-szabo mentioned this issue Sep 8, 2020
Closed
5 tasks
brapse pushed a commit that referenced this issue Sep 10, 2020
@greg-szabo
Replace amino with protobuf types (#527)
5e8eb58 
* Ripped out amino types and replaced them with protobuf types.

* Vote and proposal serialization fix

* fmt fix

* As close as test_validator_set gets without issue #506

* sad fmt noises

* Domain types for protobuf structs (#537)

* Domain types
* DomainType derive macro
* DomainType added to all amino_types

* Minor fixes and cleanup

* Fixed voting and proposals

* Updated CHANGELOG

* Documentation update
@greg-szabo greg-szabo mentioned this issue Sep 14, 2020
Merged
5 tasks
@andrey-kuprianov andrey-kuprianov mentioned this issue Sep 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@greg-szabo greg-szabo

Labels
go Compatibility with Go code
Projects
None yet
Milestone
v0.17.0
2 participants
@xla @greg-szabo