Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Model-based tests take a long time #968

Closed
hdevalence opened this issue Sep 8, 2021 · 0 comments · Fixed by #973
Closed

Model-based tests take a long time #968

hdevalence opened this issue Sep 8, 2021 · 0 comments · Fixed by #973
Assignees
@thanethomson
Labels
bug Something isn't working

Comments

@hdevalence
Copy link
Collaborator

Steps to reproduce

Running cargo test, I get

Running tests/model_based.rs (target/debug/deps/model_based-0199679b3102f8af)

running 1 test
test run_model_based_single_step_tests has been running for over 60 seconds
test run_model_based_single_step_tests ... ok

after several minutes. This increases the cycle time of working on the codebase. It would be better if the model-based tests were off by default, and ran in CI, to keep the test workflow quick-by-default.

What's the definition of "done" for this issue?

Default testing workflow is faster.
@hdevalence hdevalence added the bug Something isn't working label Sep 8, 2021
hdevalence added a commit to penumbra-zone/tendermint-rs that referenced this issue Sep 9, 2021
@hdevalence
FIX/DROP ME: ignore slow test by default
401a27d 
cf informalsystems#968
@thanethomson thanethomson self-assigned this Sep 15, 2021
@thanethomson thanethomson mentioned this issue Sep 15, 2021
Merged
5 tasks
hdevalence added a commit to penumbra-zone/tendermint-rs that referenced this issue Oct 28, 2021
@hdevalence
FIX/DROP ME: ignore slow test by default
015f352 
cf informalsystems#968
hdevalence added a commit to penumbra-zone/tendermint-rs that referenced this issue Oct 29, 2021
@hdevalence
FIX/DROP ME: ignore slow test by default
075ca0d 
cf informalsystems#968
hdevalence added a commit to penumbra-zone/tendermint-rs that referenced this issue Nov 15, 2021
@hdevalence
FIX/DROP ME: ignore slow test by default
ab93552 
cf informalsystems#968
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thanethomson thanethomson

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disable Light Client model-based tests by default informalsystems/tendermint-rs
2 participants
@hdevalence @thanethomson