Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Light Client model-based tests by default #973

Merged
merged 2 commits into from
Sep 17, 2021
Merged

Conversation

thanethomson
Copy link
Member

Closes #968

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

Signed-off-by: Thane Thomson <connect@thanethomson.com>
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@codecov-commenter
Copy link

Codecov Report

Merging #973 (eca466c) into master (80559bd) will decrease coverage by 0.0%.
The diff coverage is 90.1%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #973     +/-   ##
========================================
- Coverage    72.1%   72.1%   -0.1%     
========================================
  Files         203     203             
  Lines       16577   16585      +8     
========================================
+ Hits        11961   11965      +4     
- Misses       4616    4620      +4     
Impacted Files Coverage Δ
light-client/tests/model_based.rs 90.1% <90.1%> (+<0.1%) ⬆️
tendermint/src/signature.rs 56.6% <0.0%> (-4.1%) ⬇️
light-client/src/types.rs 29.2% <0.0%> (-0.3%) ⬇️
abci/src/server.rs 10.5% <0.0%> (+<0.1%) ⬆️
testgen/src/header.rs 80.7% <0.0%> (+0.6%) ⬆️
testgen/src/vote.rs 85.5% <0.0%> (+0.8%) ⬆️
tendermint/src/block/commit_sig.rs 78.7% <0.0%> (+2.1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80559bd...eca466c. Read the comment docs.

Copy link
Contributor

@xla xla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the one comment, this is looking good.

🏢 ☺️ 🈴 🐝

@@ -0,0 +1 @@
project_url = 'https://github.com/informalsystems/tendermint-rs'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems unrelated to the premise of this PR, could you contextualise what constitutes this change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a prerequisite for being able to automatically generate changelog entries from the CLI using unclog, as per https://github.com/informalsystems/unclog#adding-a-new-unreleased-entry

I could've probably made the change in a separate PR, but it's so small, and I had to do it anyways, that I thought I'd just add it in here.

@thanethomson thanethomson merged commit 12cc4bb into master Sep 17, 2021
@thanethomson thanethomson deleted the thane/968-mbt branch September 17, 2021 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Model-based tests take a long time
3 participants