Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v0.23.2 #1043

Merged
merged 5 commits into from
Dec 13, 2021
Merged

Release v0.23.2 #1043

merged 5 commits into from
Dec 13, 2021

Conversation

thanethomson
Copy link
Member

@thanethomson thanethomson commented Dec 7, 2021 •
edited by mzabaluev
Loading

馃摉 CHANGELOG rendered

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

Blockers

@thanethomson thanethomson changed the base branch from master to v0.23.x December 7, 2021 17:45
@thanethomson
Build changelog
10e8734 
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2021 •
edited
Loading

Codecov Report

Merging #1043 (5c201f0) into v0.23.x (1a7eafc) will decrease coverage by 0.0%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           v0.23.x   #1043     +/-   ##
=========================================
- Coverage     66.3%   66.3%   -0.1%     
=========================================
  Files          209     209             
  Lines        20974   20974             
=========================================
- Hits         13916   13915      -1     
- Misses        7058    7059      +1
Impacted Files Coverage 螖
light-client/src/lib.rs 100.0% <酶> (酶)
proto/src/lib.rs 100.0% <酶> (酶)
tendermint/src/lib.rs 100.0% <酶> (酶)
testgen/src/vote.rs 84.0% <0.0%> (-0.9%) 猬囷笍
testgen/src/validator.rs 86.7% <0.0%> (-0.8%) 猬囷笍
testgen/src/commit.rs 90.6% <0.0%> (-0.7%) 猬囷笍
testgen/src/light_block.rs 76.1% <0.0%> (-0.6%) 猬囷笍
light-client/src/types.rs 38.3% <0.0%> (酶)
tendermint/src/node.rs 63.9% <0.0%> (+0.3%) 猬嗭笍
tendermint/src/timeout.rs 85.9% <0.0%> (+1.7%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 1a7eafc...5c201f0. Read the comment docs.

@thanethomson
Bump versions to v0.23.2
b666fe3 
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@mzabaluev
Copy link
Contributor

Blocked by #1047

@thanethomson
Merge changes from #1048
f2325ff 
Signed-off-by: Thane Thomson <connect@thanethomson.com>
mzabaluev
mzabaluev reviewed Dec 9, 2021
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
thanethomson and others added 2 commits December 9, 2021 07:09
@thanethomson
Rebuild changelog
d57a7db 
Signed-off-by: Thane Thomson <connect@thanethomson.com>
@mzabaluev
Merge branch 'v0.23.x' into release/v0.23.2
5c201f0
thanethomson added a commit to thanethomson/cosmos-rust that referenced this pull request Dec 13, 2021
@thanethomson
Pin tendermint-rs deps to v0.23.1 for now
8127ae5 
As per the tendermint-rs versioning
(https://github.com/informalsystems/tendermint-rs#versioning), we're now
focusing on the v0.24.0 release for compatibility with Tendermint
v0.35.x, so any further breaking changes to the v0.23.x series of
tendermint-rs need to be released as patch versions.

This pins your tendermint-rs deps to v0.23.1 for now until we can ensure
that v0.23.2
(informalsystems/tendermint-rs#1043) does not
break anything.

Signed-off-by: Thane Thomson <connect@thanethomson.com>
This was referenced Dec 13, 2021
Merged
Closed
@thanethomson thanethomson marked this pull request as ready for review December 13, 2021 13:22
@mzabaluev
Copy link
Contributor

Checked with a pending PR to ibc-rs, looks good!

mzabaluev
mzabaluev approved these changes Dec 13, 2021
View reviewed changes
Copy link
Contributor

@mzabaluev mzabaluev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thanethomson thanethomson merged commit 8aabc22 into v0.23.x Dec 13, 2021
@thanethomson thanethomson deleted the release/v0.23.2 branch December 13, 2021 16:52
tony-iqlusion pushed a commit to cosmos/cosmos-rust that referenced this pull request Jan 5, 2022
@thanethomson
Pin tendermint-rs deps to v0.23.1 for now (#161)
cf691ba 
As per the tendermint-rs versioning
(https://github.com/informalsystems/tendermint-rs#versioning), we're now
focusing on the v0.24.0 release for compatibility with Tendermint
v0.35.x, so any further breaking changes to the v0.23.x series of
tendermint-rs need to be released as patch versions.

This pins your tendermint-rs deps to v0.23.1 for now until we can ensure
that v0.23.2
(informalsystems/tendermint-rs#1043) does not
break anything.

Signed-off-by: Thane Thomson <connect@thanethomson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mzabaluev mzabaluev mzabaluev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thanethomson @codecov-commenter @mzabaluev