Roll back time-rs dependency and remove methods that require version 0.3.5 #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not require time 0.3.5, because ibc-rs has another dependency that pins time at =0.3.2. This means the recently added methods Time::checked_add and Time::checked_sub have to be removed. Fortunately, they haven't made it into a 0.23.x release yet.
mzabaluev
added
dependencies
1 task
|
Weirdly, the two CI failures are due to two different tools failing installation over the network. These do not seem related to the change. |
thanethomson
approved these changes
Dec 8, 2021
thanethomson
added a commit
that referenced
this pull request
Dec 8, 2021
Signed-off-by: Thane Thomson <connect@thanethomson.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1047
Do not require time 0.3.5, because ibc-rs has another dependency that
pins time at =0.3.2.
This means the recently added methods
Time::checked_addandTime::checked_subhave to be removed. Fortunately, they haven't made itinto a 0.23.x release yet.
Updated all relevant documentation in docsWrote tests.changelog/