Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split out verifier parts of tendermint-light-client to tendermint-light-client-verifier #1071

Merged
merged 4 commits into from
Jan 12, 2022

Conversation

soareschen
Copy link
Contributor

Fixes #1027.

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

@soareschen soareschen added the no_std no_std compatibility label Jan 4, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2022

Codecov Report

Merging #1071 (a4d7dc7) into master (a121189) will increase coverage by 1.9%.
The diff coverage is 78.5%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #1071     +/-   ##
========================================
+ Coverage    62.7%   64.6%   +1.9%     
========================================
  Files         236     238      +2     
  Lines       21192   20571    -621     
========================================
+ Hits        13296   13307     +11     
+ Misses       7896    7264    -632     
Impacted Files Coverage Δ
light-client-js/src/lib.rs 3.7% <ø> (ø)
light-client-js/tests/web.rs 100.0% <ø> (ø)
light-client-verifier/src/errors.rs 3.7% <ø> (ø)
...client-verifier/src/operations/commit_validator.rs 98.0% <ø> (ø)
light-client-verifier/src/operations/hasher.rs 100.0% <ø> (ø)
...ght-client-verifier/src/operations/voting_power.rs 98.0% <ø> (ø)
light-client-verifier/src/options.rs 0.0% <0.0%> (ø)
light-client-verifier/src/predicates.rs 97.4% <ø> (ø)
light-client-verifier/src/verifier.rs 87.9% <ø> (ø)
light-client/examples/light_client.rs 0.0% <0.0%> (ø)
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a121189...a4d7dc7. Read the comment docs.

@soareschen soareschen marked this pull request as ready for review January 4, 2022 14:45
Copy link
Contributor

@thanethomson thanethomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've submitted #1074 with some recommendations - what do you think?

If they make sense, I can do the same for your other PR tomorrow to backport those changes to v0.23.x.

thanethomson and others added 2 commits January 12, 2022 10:16
…light-client` (#1074)

* Re-export tendermint_light_client_verifier as verifier from tendermint_light_client

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Remove unnecessary tendermint-light-client import

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Fix crate docs to reflect verifier extraction

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Add changelog entry

Signed-off-by: Thane Thomson <connect@thanethomson.com>
@soareschen
Copy link
Contributor Author

I've submitted #1074 with some recommendations - what do you think?

Looks good. Thanks!

I have also added re-export to the original paths that are exported by the tendermint-light-client crate.

@thanethomson thanethomson merged commit b52a5af into master Jan 12, 2022
@thanethomson thanethomson deleted the soares/light-client-verifier branch January 12, 2022 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no_std no_std compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split out verifier parts of tendermint-light-client to a separate no_std compliant crate
3 participants