TrustThresholdFraction: allow to be initialized with value 1

.changelog/unreleased/bug-fixes/1208-trustthresholdfraction-check.md

@@ -0,0 +1,2 @@
+- Allow a `TrustThresholdFraction` of 1  
+  ([#1208](https://github.com/informalsystems/tendermint-rs/issues/1208))

tendermint/proptest-regressions/trust_threshold.txt

@@ -0,0 +1,7 @@
+# Seeds for failure cases proptest has generated in the past. It is
+# automatically read and these particular cases re-run before any
+# novel cases are generated.
+#
+# It is recommended to check this file in to source control so that
+# everyone who runs the test benefits from these saved cases.
+cc 5f12a01ebfd5d2efb4e16c1267e4d876465cfa3294d159abf2051d5aba03f74c # shrinks to num = 1

tendermint/src/trust_threshold.rs

@@ -54,7 +54,7 @@ impl TrustThresholdFraction {
     /// The parameters are valid iff `1/3 <= numerator/denominator < 1`.
     /// In any other case we return an error.
     pub fn new(numerator: u64, denominator: u64) -> Result<Self, Error> {
-        if numerator >= denominator {
+        if numerator > denominator {
             return Err(Error::trust_threshold_too_large());
         }
         if denominator == 0 {
@@ -159,12 +159,6 @@ mod test {
             assert!(from_json(num, denom).is_err());
         }
 
-        #[test]
-        fn cannot_be_one(num in 1..1000u64) {
-            assert!(TrustThresholdFraction::new(num, num).is_err());
-            assert!(from_json(num, num).is_err());
-        }
-
         #[test]
         fn undefined(num in 1..1000u64) {
             // Numerator should be irrelevant
@@ -191,5 +185,11 @@ mod test {
             assert_eq!(frac.numerator(), num);
             assert_eq!(frac.denominator(), denom);
         }
+
+        #[test]
+        fn can_be_one(num in 1..1000u64) {
+            assert!(TrustThresholdFraction::new(num, num).is_ok());
+            assert!(from_json(num, num).is_ok());
+        }
     }
 }