Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TrustThresholdFraction: allow to be initialized with value 1 #1209

Merged
merged 4 commits into from
Oct 25, 2022

Conversation

plafer
Copy link
Contributor

@plafer plafer commented Oct 12, 2022

Closes: #1208

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

Copy link
Contributor

@mzabaluev mzabaluev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, we should follow what the Go implementation does here.

Fix the docs and it should be good to go.
The rustdoc problem should have been fixed in #1212, so merge/rebase to get rid of it.

@@ -54,7 +54,7 @@ impl TrustThresholdFraction {
/// The parameters are valid iff `1/3 <= numerator/denominator < 1`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doc needs to be updated too, then?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov-commenter
Copy link

Codecov Report

Merging #1209 (7c4888a) into main (035acab) will decrease coverage by 0.0%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main   #1209     +/-   ##
=======================================
- Coverage   64.0%   63.9%   -0.1%     
=======================================
  Files        253     253             
  Lines      21636   21636             
=======================================
- Hits       13851   13839     -12     
- Misses      7785    7797     +12     
Impacted Files Coverage Δ
tendermint/src/trust_threshold.rs 92.9% <100.0%> (ø)
config/src/config.rs 54.7% <0.0%> (-1.3%) ⬇️
testgen/src/header.rs 82.9% <0.0%> (-1.2%) ⬇️
testgen/src/vote.rs 84.0% <0.0%> (-0.9%) ⬇️
light-client-verifier/src/types.rs 38.1% <0.0%> (-0.6%) ⬇️
abci/src/server.rs 9.2% <0.0%> (-0.2%) ⬇️
tendermint/src/node.rs 64.1% <0.0%> (+0.1%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@plafer plafer merged commit 5055884 into main Oct 25, 2022
@plafer plafer deleted the plafer/1208-TrustThresholdFraction branch October 25, 2022 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TrustThresholdFraction slightly too restrictive
4 participants