Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix VotingPowerCalculator::voting_power_in #306

Merged
merged 12 commits into from
Jun 19, 2020
Merged

Fix VotingPowerCalculator::voting_power_in #306

merged 12 commits into from
Jun 19, 2020

Commits on Jun 18, 2020

  1. Fix VotingPowerCalculator::voting_power_in. 

    - Provide two helper methods for checking validators overlap and if
  there is enough trust w.r.t. the trusted state.
- Only count `Commit` signatures towards the voting power.
- Do not rely on `signed_votes` method to get the votes.
    @romac
    romac committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    208cf97 View commit details
    Browse the repository at this point in the history

  2. Don't add voting power of the same validator multiple times

    @romac
    romac committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    024a73d View commit details
    Browse the repository at this point in the history

  3. Cleanup and comments

    @romac
    romac committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    c828155 View commit details
    Browse the repository at this point in the history

  4. Remove debug statements

    @romac
    romac committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    319c9f2 View commit details
    Browse the repository at this point in the history

  5. Add a constant for a trust threshold of 2/3

    @romac
    romac committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    e9c51a0 View commit details
    Browse the repository at this point in the history

  6. Fix clippy warnings

    @romac
    romac committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    90c32ba View commit details
    Browse the repository at this point in the history

  7. Mention #235 in TODO comment

    @romac
    romac committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    8c0c5e6 View commit details
    Browse the repository at this point in the history

  8. Small refactor

    @romac
    romac committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    7e3b537 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2020

  1. Fix clippy warnings and a typo

    @romac
    romac committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    ef3660c View commit details
    Browse the repository at this point in the history

  2. Address Stevan's comments

    @romac
    romac committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    30d680f View commit details
    Browse the repository at this point in the history

  3. Remove debug condition

    @romac
    romac committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    2f45b73 View commit details
    Browse the repository at this point in the history

  4. Raise error when seeing duplicate validator in voting power computation

    @romac
    romac committed Jun 19, 2020
    Configuration menu
    Copy the full SHA
    fc5e89f View commit details
    Browse the repository at this point in the history