Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Light Client model-based tests by default #973

Merged
merged 2 commits into from
Sep 17, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .changelog/config.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
project_url = 'https://github.com/informalsystems/tendermint-rs'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change seems unrelated to the premise of this PR, could you contextualise what constitutes this change?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a prerequisite for being able to automatically generate changelog entries from the CLI using unclog, as per https://github.com/informalsystems/unclog#adding-a-new-unreleased-entry

I could've probably made the change in a separate PR, but it's so small, and I had to do it anyways, that I thought I'd just add it in here.

3 changes: 3 additions & 0 deletions .changelog/unreleased/improvements/968-mbt.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
- `[tendermint-light-client]` Model-based tests are now disabled
by default and can be enabled through the `mbt` feature
([#968](https://github.com/informalsystems/tendermint-rs/issues/968))
2 changes: 2 additions & 0 deletions light-client/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,8 @@ unstable = []
std = [
"flex-error/std"
]
# Enable to execute long-running model-based tests
mbt = []

[dependencies]
tendermint = { version = "0.21.0", path = "../tendermint" }
Expand Down
Loading