Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotation list #1886

Merged
merged 58 commits into from
Jan 15, 2020
Merged

Annotation list #1886

merged 58 commits into from
Jan 15, 2020

Conversation

vipul-21
Copy link
Contributor

@vipul-21 vipul-21 commented Dec 17, 2019

This PR is new implementation for annotation being displayed on the left side. It overlays svg on tiff with the updated version of openseadragon.
The changes are being made to the viewer app to:

iamyle0710 and others added 30 commits September 22, 2019 12:51
@jrchudy
Copy link
Member

jrchudy commented Dec 17, 2019

Could you update this PR with some information explaining what the purpose behind the changes are? Possibly link the issue related to this PR as well for further context?

@vipul-21 vipul-21 requested a review from RFSH December 18, 2019 04:40
@vipul-21
Copy link
Contributor Author

@jrchudy Added comment regarding PR. Since we have been working on this for a long time, there might be a lot of changes in the code. I have tried to comment the new code which has been added.

Copy link
Member

@jrchudy jrchudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes seem to be stable. I'm not sure how the left panel functionality is supposed to work, I tested here:
https://dev.rebuildingakidney.org/~vipul/chaise/viewer/#2/Gene_Expression:Image/id=N-FGK2

and wasn't able to expand the panel or add any annotations. No errors were thrown in the view, but there was a minor error thrown in the console.

Can you point me to a better link to test this with? If what I'm seeing with the side panel is the expectation, then we can merge this.

@vipul-21
Copy link
Contributor Author

vipul-21 commented Jan 7, 2020

Currently there are no annotation available on the dev server. This is the link for scene with svg overlay where you can see the left panel.
The viewer app should work for both types of format tiff and czi. Here's the link where I was testing.
Note: Support for both file formats and screenshot are still on a separate branch of openseadragon-viewer app and they are on this PR.

@vipul-21 vipul-21 merged commit 6bcab6a into master Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants