-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Annotation list #1886
Annotation list #1886
Conversation
- Add stroke width scale feature
- adjust stroke scale input style
- Add stroke width scale feature
- adjust stroke scale input style
…edu/chaise into annotation-list
…edu/chaise into annotation-list
…edu/chaise into annotation-list
…se into annotation-list
Could you update this PR with some information explaining what the purpose behind the changes are? Possibly link the issue related to this PR as well for further context? |
@jrchudy Added comment regarding PR. Since we have been working on this for a long time, there might be a lot of changes in the code. I have tried to comment the new code which has been added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes seem to be stable. I'm not sure how the left panel functionality is supposed to work, I tested here:
https://dev.rebuildingakidney.org/~vipul/chaise/viewer/#2/Gene_Expression:Image/id=N-FGK2
and wasn't able to expand the panel or add any annotations. No errors were thrown in the view, but there was a minor error thrown in the console.
Can you point me to a better link to test this with? If what I'm seeing with the side panel is the expectation, then we can merge this.
Currently there are no annotation available on the dev server. This is the link for scene with svg overlay where you can see the left panel. |
This PR is new implementation for annotation being displayed on the left side. It overlays svg on tiff with the updated version of openseadragon.
The changes are being made to the viewer app to:
It also resolves the following issues Reference coordinate alignment problems in svg #1840 and viewer: incorporate the svg objects ontop of open-seadragon in the viewerapp #1779.