-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Saved query logging #2137
Merged
Merged
Saved query logging #2137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the model values from the facet obj
…owing user to save
…in github. Add 3 chaise config properties for the thresholds. Add a comment describing the behavior of default name and description.
…er to edit the existing query or cancel to modify the facet criteria
…ert to allow for tracking alerts in their own array separate from the main page
…ion to allow for an external close function to remove alerts from an external alerts array that isn't controled by the alerts service
…ore won't include this boolean
…s based on how we want it to behave instead of just based on other properties being set
…hanges related to logging
RFSH
reviewed
Jan 4, 2022
RFSH
reviewed
Jan 4, 2022
RFSH
approved these changes
Jan 6, 2022
This was referenced Jan 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the logging improvements for the saved query functionality for the actions associated with saving queries and viewing the set to apply one on recordset. More details about the logging changes/additions can be found in the attached issue (#2122 )
Also included in this PR:
;
characterpcid
andppid
to recordedit link that redirects after a successful submission