Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with other plugins that use preprocess/typescript #29

Open
tstackhouse opened this issue Apr 15, 2021 · 3 comments
Open

Incompatible with other plugins that use preprocess/typescript #29

tstackhouse opened this issue Apr 15, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@tstackhouse
Copy link

tstackhouse commented Apr 15, 2021

I left a comment on another issue here, however after looking into this more, it really seems like it's a larger issue surrounding how preprocessing works in the cypress ecosystem. I'm using Nx in my project, which has its own preprocessor that handles adding the bits that it needs to the typescript environment and handles compiling the TS internally. There's an (incorrectly marked as stale) issue in the Nx repo here, revolving around the native Cypress support for TS, but it seems like it may not be a simple thing to just drop out, as their preprocessor does more than just modifying the source files. There also seems to be an open issue in the cypress repo here regarding support for multiple preprocessors.

Since this plugin using TS to traverse the AST and do its processing, what's to stop it from outputting TS code again rather than compiling out to JS? Especially if the tests need additional "stuff" to make them work properly.

I realize this is a bit of a rambley mess, but there are a fair number of moving parts involved in this.

Referenced issues:

@annaet
Copy link
Contributor

annaet commented Apr 26, 2021

Hi @tstackhouse

Thanks for raising this issue, I think what you've suggested makes sense. So I will take a look at the code we're outputting and see if I can help with your issue.

@annaet annaet added the enhancement New feature or request label Apr 26, 2021
@stale
Copy link

stale bot commented Aug 5, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Marked as stale due to inactivity label Aug 5, 2021
@annaet annaet removed the stale Marked as stale due to inactivity label Aug 5, 2021
@stale
Copy link

stale bot commented Oct 4, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Marked as stale due to inactivity label Oct 4, 2021
@annaet annaet removed the stale Marked as stale due to inactivity label Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants