Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated WMS params lowercase vs uppercase #519

Merged
merged 6 commits into from
Nov 26, 2019
Merged

Duplicated WMS params lowercase vs uppercase #519

merged 6 commits into from
Nov 26, 2019

Conversation

pelord
Copy link
Member

@pelord pelord commented Nov 22, 2019

Please check if the PR fulfills these requirements

What is the current behavior? (You can also link to an open issue here)
Some wms params were duplicated.

**What is the new behavior?
Openlayers strictly interpreting wms params in uppercase. We now redirect all wms params to uppercase.

In case of lowercase user defined wms params, all users wms params will be kept. But every params will be converted into uppercase.

In case of duplicated param (uppercase & lowercase), the priority remain to the lowercase property (or the property containning less upercase letters). In the next example, the priority to this user defined property is accorded to layers

ex:

        "params": {
          "LAYERS": "telephone_urg",
          "lAYERS": "telephone_urg",
          "laYERS": "telephone_urg",
          "layERS": "telephone_urg",
          "layeRS": "telephone_urg",
          "layerS": "telephone_urg",
          "layers": "telephone_urg"
        }

Does this PR introduce a breaking change? (check one with "x")

[x] Yes
[x] No

For wms params defined bycode, the wms interface params are now in uppercase.

@pelord pelord changed the title Double params Duplicated WMS params lowercase vs uppercase Nov 22, 2019
@pelord
Copy link
Member Author

pelord commented Nov 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants