Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(map utils): conversion to latitude longitude out of bounds #858

Merged
merged 1 commit into from
May 17, 2021

Conversation

pelord
Copy link
Member

@pelord pelord commented May 13, 2021

Please check if the PR fulfills these requirements

What is the current behavior? (You can also link to an open issue here)
When 2 numeric terms are search and these are not coordinates, the app detect a coordinate type. The app convert the provided coords into longitude/latitude coords. The app crash

https://infra-geo-ouverte.github.io/igo2/?search=000012392110001%200001320192110001

What is the new behavior?
If the longitude latitude coords are out of bounds, (180 to -180 and -90 to 90), the reversesearch is not triggered.

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications:

Other information:

@mbarbeau mbarbeau merged commit 6a5a211 into next May 17, 2021
@mbarbeau mbarbeau deleted the lonLat branch May 17, 2021 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants