Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ogc-time): allow alias to ogc-filter-time section #981

Merged
merged 5 commits into from
Feb 22, 2022

Conversation

PhilippeLafreniere18
Copy link
Contributor

Please check if the PR fulfills these requirements

What is the current behavior? (You can also link to an open issue here)
Alias is not allowed for ogc-filter-time section

What is the new behavior?
An alias can now be added to the top of the section

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

@PhilippeLafreniere18
Copy link
Contributor Author

@pelord
Copy link
Member

pelord commented Feb 16, 2022

@josee666 Est-ce que tu peux tester svp?

@josee666
Copy link

C'est conforme pour ma part!

@PhilippeLafreniere18
Copy link
Contributor Author

@josee666 à retester. Après discussion avec @pelord , nous avons convenu de réutiliser l'alias du sourceField au lieu de répéter l'attribut dans le filter.

Prochaine bonification serait de pouvoir en mettre plusieurs et de faire l'association correctement par name.

@PhilippeLafreniere18 PhilippeLafreniere18 merged commit 55c634a into next Feb 22, 2022
@PhilippeLafreniere18 PhilippeLafreniere18 deleted the aliasOGCTime branch February 23, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants