fix: ignore parent terragrunt.hcl files in a Terragrunt directory #2334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugorut
force-pushed
the
fix/terragrunt-auto-detect
branch
from
c75c3b7
to
bde8191
Compare
|
I have an open pr here #2335 for the intermitently failing golangci-lint errors, so please ignore |
vdmgolub
approved these changes
Mar 7, 2023
| continue | ||
| } | ||
|
|
||
| file, err := os.Open(file) |
There was a problem hiding this comment.
Do we need to close these files? Or should it not be that many to care as the execution is usually quick?
There was a problem hiding this comment.
Yes we should, for some reason the file.Close wasn't being recognized with my specific build tags so it got removed with go fmt I'm adding back in. Good spot.
hugorut
force-pushed
the
fix/terragrunt-auto-detect
branch
3 times, most recently
from
2d1955f
to
d01bf76
Compare
Resolves issue when a parent `terragrunt.hcl` file was using any `find` or `get` functions. These functions are called relative to the original Terragrunt config (the child `terragrunt.hcl` file). Thus any file include would fail with a not exists error. We now ignore parent `terragrunt.hcl` from initial evaluation and only read it when it is included by a child `terragrunt.hcl` (expected behaviour).
hugorut
force-pushed
the
fix/terragrunt-auto-detect
branch
from
d01bf76
to
8b4a4dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue when a parent
terragrunt.hclfile was using anyfindorgetfunctions. These functions are called relative to the original Terragrunt config (the childterragrunt.hclfile). Thus any file include would fail with a not exists error. We now ignore parentterragrunt.hclfrom initial evaluation and only read it when it is included by a childterragrunt.hcl(expected behaviour).