fix: bump golangci-lint version to prevent fmt panic #2335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugorut
force-pushed
the
fix/golangci-lint-fix
branch
2 times, most recently
from
d19d9d1
to
71ccc31
Compare
hugorut
force-pushed
the
fix/golangci-lint-fix
branch
from
71ccc31
to
76288b0
Compare
tim775
approved these changes
Mar 7, 2023
| @@ -54,7 +54,7 @@ func commentGitHubCmd(ctx *config.RunContext) *cobra.Command { | |||
| } | |||
|
|
|||
| tlsConfig.RootCAs = rootCAs | |||
| tlsConfig.InsecureSkipVerify = tlsInsecureSkipVerify | |||
| tlsConfig.InsecureSkipVerify = tlsInsecureSkipVerify // nolint: gosec | |||
There was a problem hiding this comment.
nice, i didn't think there were pragmas but i guess that's just golint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
terraform-aws-providersee fix: change arn to pass terraform cli validation #2337