Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lion-select-rich]: Single option support lazy loaded #677

Closed
palash2601 opened this issue Apr 10, 2020 · 4 comments
Closed

[lion-select-rich]: Single option support lazy loaded #677

palash2601 opened this issue Apr 10, 2020 · 4 comments
Labels
enhancement New feature or request

Comments

@palash2601
Copy link
Contributor

Feature request

When there is only a single option available in the listbox of lion-select-rich, an attribute singleOption should be added invoker element so that desired styling can be defined by the extended component.

Also since it is a single option will be available, it should not open overlay which displays the option

@tlouisse
Copy link
Member

tlouisse commented Apr 14, 2020

@palash2601 thanks for your pull request 💪 Although the related pr is already merged, there are still a few things that need to be tackled (also see the comments on the pr):

  • could you add some docs? Maybe a story that explains what it does.
  • could you add a test that handles dynamically added options (support for lazily loaded options). For this, you could hook into addFormElement and removeFormElement.
  • could you maybe change attr name to single-option?
  • it's recommended to use this.formElements.length for checking the amount of children (since it is allowed to add more visual sibling elements)
  • the rich-select was designed to closely mimic the native select. Maybe we can make this an opt-in flag that you enable by default on your extension layer?

@gerjanvangeest
Copy link
Member

Updated in: #682

@jorenbroekema jorenbroekema added enhancement New feature or request votes needed Enhancement available for voting labels Jul 27, 2020
@jorenbroekema jorenbroekema changed the title [lion-select-rich]: Attribute for single option [lion-select-rich]: Single option support lazy loaded Jul 27, 2020
@jorenbroekema
Copy link
Collaborator

Closing as enhancement for lazy loaded single-option with votes needed

@daKmoR
Copy link
Collaborator

daKmoR commented Sep 28, 2020

this has been implemented - if there is still something open please feel free to create a dedicated issue for it 🤗

"closing" this feature request

@daKmoR daKmoR removed the votes needed Enhancement available for voting label Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants