Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: remove code duplication #165

Closed
sbrugman opened this issue Oct 21, 2021 · 0 comments
Closed

Refactor: remove code duplication #165

sbrugman opened this issue Oct 21, 2021 · 0 comments
Labels
enhancement New feature or request internal improvement refactoring and testing

Comments

@sbrugman
Copy link
Collaborator

Parts of the API in the code contains substantial amounts of duplicated code. Examples are arguments and docstrings that are defined for multiple levels or nested functions. An example is the regenerate function.

Pylint can be used to detect these issues in part:

-   repo: https://github.com/pycqa/pylint
     rev: pylint-2.6.0
     hooks:
     -   id: pylint

Refactoring the code improves readability and maintainability.

Arguments can be passed via **kwargs, perhaps we would like to use docrep to propagate the docstrings.

@sbrugman sbrugman added enhancement New feature or request internal improvement refactoring and testing labels Oct 21, 2021
@sbrugman sbrugman linked a pull request Jun 15, 2022 that will close this issue
@sbrugman sbrugman removed a link to a pull request Jun 15, 2022
@sbrugman sbrugman closed this as completed Jul 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request internal improvement refactoring and testing
Projects
None yet
Development

No branches or pull requests

1 participant