Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with pydantic when using some custom settings in the report generation #239

Closed
gus-morales opened this issue Jul 8, 2022 · 3 comments

Comments

@gus-morales
Copy link

With version 1.0.0, when using custom settings in df.pm_stability_report() like show_stats, I get an error stating such option is not allowed:

ValidationError: 2 validation errors for Settings

I couldn't reproduce it when using popmon==0.9.0.

@mbaak
Copy link
Contributor

mbaak commented Jul 8, 2022

Thanks for reporting! Will try to reproduce this.

@sbrugman
Copy link
Collaborator

sbrugman commented Jul 12, 2022

@gus-morales The syntax for configuration has changed (the version increase indicates a breaking change). Are you using the new syntax? The validation errors should actually be a feature, not a bug.

The docs provide examples and descriptions of how to configure popmon. The full range of options can be found in the config.py.

Specifically for show_stats the code would look somewhat like this:

from popmon.config import Settings

settings = Settings()
settings.report.show_stats = ["distinct*",
        "filled*",
        "nan*",
        "mean*",
]

df.pm_stability_report(settings=settings)

@sbrugman
Copy link
Collaborator

sbrugman commented Aug 19, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants