Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gather and/or duplicate metrics container #38

Closed
marminthibaut opened this issue Oct 10, 2015 · 3 comments
Closed

Gather and/or duplicate metrics container #38

marminthibaut opened this issue Oct 10, 2015 · 3 comments

Comments

@marminthibaut
Copy link
Member

We have to choose between:

  • gather all statistics (cpu, blkio, container, etc.) into a unique and big event
  • remove the container event, and duplicate container information to all other metrics

We should compare to topbeat and packetbeat to see their logics.

@erwanncloarec
Copy link
Contributor

Well in both Topbeat & Packetbeat, the events are separated. In Topbeat, the events are even seperated per process! I don't see why we should not do the same thing.
It is a benefit because it is clearer in ES when it is seperated, and more easy to query.
We can also have a benefit if there is a metric that no longer exist, we can still have the others.

@marminthibaut
Copy link
Member Author

I think we could adopt the second choice: remove the container event, and duplicate container information to all other metrics.

@marminthibaut marminthibaut self-assigned this Jan 5, 2016
@marminthibaut
Copy link
Member Author

Nothing to do:

we keep the five types:

  • container
  • memory
  • cpu
  • net
  • blkio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants