Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python support #3

Merged
merged 2 commits into from
Jul 22, 2014
Merged

Python support #3

merged 2 commits into from
Jul 22, 2014

Conversation

michael-donat
Copy link

Credits to http://sizer99.com/tf/

Patch applied manually (- the mmalloc MAC fix that has been fixed previously)

@@ -0,0 +1,585 @@
#
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please move all py files to different folder .... eg py-lib/ or python/ or tf-lib/python/

Cause now py and tf files are mixed..

@ingwarsw
Copy link
Owner

Great job..

Lua support should be factored to similar faction..
Or removed cause it looks like python support is far more robust..

@michael-donat
Copy link
Author

Couldn’t quite compile lua on osx, will open up an issue with details later on.

On 20 Jul 2014, at 19:49, Karol Lassak notifications@github.com wrote:

Great job..

Lua support should be factored to similar faction..
Or removed cause it looks like python support is far more robust..


Reply to this email directly or view it on GitHub.

@ingwarsw
Copy link
Owner

I didn't mean you have to fix lua support :)

I meant that should be made as robust as python ..

@michael-donat
Copy link
Author

I know, just getting the note out there ;)

@michael-donat
Copy link
Author

So far it's just the source that I've changed. make install will still move both sets into share/tf-lib, we can have a look into further splitting it there too, but then the usual load/python_load methods will also need adjustment.

ingwarsw added a commit that referenced this pull request Jul 22, 2014
@ingwarsw ingwarsw merged commit 0063f70 into ingwarsw:master Jul 22, 2014
@ingwarsw
Copy link
Owner

Ok thanks..

We should do full spliting...
And also lua sources should go to separate dir under lib

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants