don't give up on symlinks amongst files to install #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doesn't -f check to see if symlink is a file. ie if $symlink terminates in an existing file -e would also be true for directories and I'm not sure how that would play out. |
|
Yeah, I don't mind fixing it harder, this was just enough to keep going. if (-d $file || -l $file && -f readlink $file)I think that's better. |
ingydotnet
added a commit
that referenced
this pull request
Nov 14, 2013
|
fixed in 71af819 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to install my new vim-dots, and I kept getting complaints that some file didn't exist. It did, but it was a symlink to a file elsewhere in the repo, rather than a plain file. This relaxes the check.