Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape :: to avoid weird bug #30

Merged
merged 1 commit into from
Jul 5, 2016
Merged

Conversation

nfg
Copy link
Contributor

@nfg nfg commented Jul 4, 2016

I think this is the same bug from PR #16. Basically, using the latest
YAML release (1.16), I can run this test script and trigger the bug:

use strict;
use warnings;

use Module::Runtime 'use_module';
use Safe;

my $safe = Safe->new;

use_module('YAML');

print YAML::Dump( { yarr => 1 } );

Resulting in:

mo-pm git:bugfix-issue_24 ❯ perl test2.pl
Undefined subroutine &main::main:: called at /home/ad/nigelg/.plenv/versions/new5203/lib/perl5/site_perl/5.20.3/YAML/Mo.pm line 5.

After rebuilding Mo and running mo-inline on YAML/Mo.pm, I get:

mo-pm git:bugfix-issue_24 ❯ perl test2.pl

---
yarr: 1

I think this is the same bug from PR#16. Basically, using the latest
YAML release (1.16), I can run this test script and trigger the bug:

    use strict;
    use warnings;

    use Module::Runtime 'use_module';
    use Safe;

    my $safe = Safe->new;

    use_module('YAML');

    print YAML::Dump( { yarr => 1 } );

Resulting int:

    mo-pm git:bugfix-issue_24 ❯ perl test2.pl
    Undefined subroutine &main::main:: called at /home/ad/nigelg/.plenv/versions/new5203/lib/perl5/site_perl/5.20.3/YAML/Mo.pm line 5.

After rebuilding Mo and running mo-inline on YAML/Mo.pm, I get:

    mo-pm git:bugfix-issue_24 ❯ perl test2.pl
    ---
    yarr: 1
veryrusty added a commit to veryrusty/mo-pm that referenced this pull request Jul 5, 2016
Issue ingydotnet#24 noted an Undefined subroutine &main::main:: error that needed
tests and a patch. ingydotnet#30 has a patch; and here's a simple test to tickle
it.
@perlpunk perlpunk merged commit 4c1f40f into ingydotnet:master Jul 5, 2016
perlpunk pushed a commit that referenced this pull request Jul 5, 2016
Issue #24 noted an Undefined subroutine &main::main:: error that needed
tests and a patch. #30 has a patch; and here's a simple test to tickle
it.
perlpunk pushed a commit that referenced this pull request Jul 5, 2016
@perlpunk
Copy link
Collaborator

perlpunk commented Jul 5, 2016

Applied and pushed to master. Will release tomorrow.

@perlpunk
Copy link
Collaborator

perlpunk commented Jul 5, 2016

FWIW, the new Mo code was injected into YAML::Mo and YAML-0.17 was released.

@nfg nfg deleted the bugfix-issue_24 branch July 5, 2016 20:35
@nfg
Copy link
Contributor Author

nfg commented Jul 5, 2016

Yay! Thank you. I'm glad to have helped. :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants