Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output settings in default_config for new devices are not loading #282

Closed
ayushchand opened this issue Oct 3, 2020 · 2 comments · Fixed by #359
Closed

Output settings in default_config for new devices are not loading #282

ayushchand opened this issue Oct 3, 2020 · 2 comments · Fixed by #359

Comments

@ayushchand
Copy link

ayushchand commented Oct 3, 2020

device/drivers/manifest.enaml file lists a default_config for Silhouette devices with Output settings.

        DeviceDriver:
            manufacturer = 'Silhouette'
            model = 'Cameo 4'
            width = '300cm'
            length = '30.5cm'
            protocols = ['gpgl']
            connections = ['printer']
            default_config = {
              'scale': [ 5.64, 5.64 ],
              'swap_xy': True,
              'mirror_x': True,
              'mirror_y': True
            }

Adding a new device from GUI does not initialize the output settings and protocol type.

@Schubisu
Copy link

Thanks @ayushchand,
I've just received my Cameo 4 and faceed this issue. As a workaround I deleted the default_config from device/drivers/manifest.enaml and added it manually in the GUI again.

@karliss
Copy link
Contributor

karliss commented Sep 26, 2022

I just noticed this as well when working on different issue. After adding some debug logs it seemed like part of problem was that code responsible from initializing stuff based on default config gets executed only when creating a new device before you have selected driver. So your new device gets initialized with default config from whatever driver happens to be first in the list.

This needs to be solved with care since user might want to keep some of the settings when switching driver or at least write them down. Maybe some kind of confirmation window when you do it: "Do you want to apply default settings from the selected driver, previous settings will be lost? Yes/No/Cancel". Or maybe ask to choose driver before creation of new device.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants