Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Download command failed on MacOS #32

Closed
alexellis opened this issue Jan 23, 2020 · 1 comment · Fixed by #33
Closed

Download command failed on MacOS #32

alexellis opened this issue Jan 23, 2020 · 1 comment · Fixed by #33

Comments

@alexellis
Copy link
Member

Expected Behaviour

inletsctl download --pro should get me a MacOS binary when using Mac, but it was a Linux binary that was downloaded

Possible Solution

Add unit tests and fix bug.

Steps to Reproduce (for bugs)

  1. Use a Mac
  2. Run inletsctl download --pro
  3. See the wrong binary, it downloads for Linux

cc @Waterdrips
alexellis added a commit that referenced this issue Jan 23, 2020
@alexellis
Fix issue 32 for download on MacOS
00074b1 
Added unit tests to make sure the binary name is created as
per the releases page. Tested on MacOS and with new unit tests
to show no regression for Linux etc.

Fixes: #32

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
@alexellis alexellis mentioned this issue Jan 23, 2020
Merged
@alexellis
Copy link
Member Author

@Waterdrips perhaps you can write a Go unit test that runs the command then checks the binary is as expected? I used the file utility to find the binary format was correct.

file /usr/local/bin/inlets-pro 
/usr/local/bin/inlets-pro: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, stripped

There may be other ways to do this too.

alexellis added a commit that referenced this issue Jan 23, 2020
@alexellis
Fix issue 32 for download on MacOS
91b95ac 
Added unit tests to make sure the binary name is created as
per the releases page. Tested on MacOS and with new unit tests
to show no regression for Linux etc.

Fixes: #32

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issue 32 for download on MacOS inlets/inletsctl
1 participant
@alexellis