Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in plot_isi_histogram for default cutoff value #30

Closed
JuliaSprenger opened this issue Dec 1, 2020 · 2 comments · Fixed by #31
Closed

Error in plot_isi_histogram for default cutoff value #30

JuliaSprenger opened this issue Dec 1, 2020 · 2 comments · Fixed by #31

Comments

@JuliaSprenger
Copy link

For viziphant version 0.1.0 the usage of the default parameters for the plot_isi_histogram results in

'numpy.float64' object has no attribute 'rescale'

Here is a minimal breaking example

st = neo.SpikeTrain([1,2,3]*pq.s,t_stop=10*pq.s)
viziphant.statistics.plot_isi_histogram(spiketrains)
@dizcza
Copy link
Contributor

dizcza commented Dec 1, 2020

Thanks, your script actually spot two bugs in ISI plotting ;)

@dizcza
Copy link
Contributor

dizcza commented Dec 1, 2020

Don't know how to test viziphant other than calling the functions all possible ways to check that no error is triggered.
Currently, I test the doc tests only. But it'll become an issue quickly if viziphant starts growing.

@dizcza dizcza closed this as completed in #31 Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants