Add automated legacy releases to *.x branches
#224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jpwilliams
added a commit
that referenced
this pull request
Jun 9, 2023
## Summary This handy action allows us to backport a PR to a particular branch when merged using labels.  Just add the label, then when the PR is merged a new PR will be opened to the relevant branch (e.g. `1.x`) to backport the squashed commit. This does not manage releasing; we'll use changesets for that. ## Related - #224
inngest-release-bot
pushed a commit
that referenced
this pull request
Jun 9, 2023
## Summary This handy action allows us to backport a PR to a particular branch when merged using labels.  Just add the label, then when the PR is merged a new PR will be opened to the relevant branch (e.g. `1.x`) to backport the squashed commit. This does not manage releasing; we'll use changesets for that. ## Related - #224 (cherry picked from commit efc37dc)
darwin67
approved these changes
Jun 9, 2023
inngest-release-bot
pushed a commit
that referenced
this pull request
Jun 9, 2023
## Summary Use `*.x` branches such as `1.x` with changesets to create automated release PRs, similar to those to `@latest`. Here, we add a small script to generate a dynamic config for these branches so that changesets knows what to compare against. Also includes a small change to rename release PRs to either `Release @latest` or (for example) `Release @1.x`. ## Related - #223 (cherry picked from commit 634e2d6)
jpwilliams
added a commit
that referenced
this pull request
Jun 12, 2023
…gs (#236) ## Summary The release script in #224 and #230 almost worked. We see in run to release a `v1.x` backport that the following command failed: https://github.com/inngest/inngest-js/actions/runs/5244055017/jobs/9469531269 ``` $ npm dist-tag add inngest@2.0.1 latest npm ERR! code E401 npm ERR! 401 Unauthorized - PUT https://registry.yarnpkg.com/-/package/inngest/dist-tags/latest ``` Looks like it's defaulting to using Yarn's registry URL instsead of npm's. We get around this during publishing as we specify `publishConfig.registry` in our `package.json`, but it seems that `npm dist-tag` doesn't obey this same property. Let's manually set the registry for this particular command to ensure it tries to affect the right place. ## Related - #224 - #230
inngest-release-bot
pushed a commit
that referenced
this pull request
Jun 12, 2023
…gs (#236) ## Summary The release script in #224 and #230 almost worked. We see in run to release a `v1.x` backport that the following command failed: https://github.com/inngest/inngest-js/actions/runs/5244055017/jobs/9469531269 ``` $ npm dist-tag add inngest@2.0.1 latest npm ERR! code E401 npm ERR! 401 Unauthorized - PUT https://registry.yarnpkg.com/-/package/inngest/dist-tags/latest ``` Looks like it's defaulting to using Yarn's registry URL instsead of npm's. We get around this during publishing as we specify `publishConfig.registry` in our `package.json`, but it seems that `npm dist-tag` doesn't obey this same property. Let's manually set the registry for this particular command to ensure it tries to affect the right place. ## Related - #224 - #230 (cherry picked from commit f33464f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use
*.xbranches such as1.xwith changesets to create automated release PRs, similar to those to@latest.Here, we add a small script to generate a dynamic config for these branches so that changesets knows what to compare against.
Also includes a small change to rename release PRs to either
Release @latestor (for example)Release @1.x.Related