Add support for publishing legacy versions in release script #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
goodoldneon
approved these changes
Jun 12, 2023
tonyhb
approved these changes
Jun 12, 2023
inngest-release-bot
pushed a commit
that referenced
this pull request
Jun 12, 2023
## Summary Releasing earlier versions to npm is a pain. This PR ensures we: 1. Find the actual latest version of the package 2. Publish the legacy version using the `latest` tag, ensuring semver updates work as expected 3. Re-tag `latest` as the version found in step 1 Following this, we should be ready to support backporting and legacy releases purely with labels and PRs. 🥳 ## Related - mermaid-js/mermaid#4200 - bower/bower#2041 - npm/npm#6778 (cherry picked from commit 55c3b1c)
jpwilliams
added a commit
that referenced
this pull request
Jun 12, 2023
…gs (#236) ## Summary The release script in #224 and #230 almost worked. We see in run to release a `v1.x` backport that the following command failed: https://github.com/inngest/inngest-js/actions/runs/5244055017/jobs/9469531269 ``` $ npm dist-tag add inngest@2.0.1 latest npm ERR! code E401 npm ERR! 401 Unauthorized - PUT https://registry.yarnpkg.com/-/package/inngest/dist-tags/latest ``` Looks like it's defaulting to using Yarn's registry URL instsead of npm's. We get around this during publishing as we specify `publishConfig.registry` in our `package.json`, but it seems that `npm dist-tag` doesn't obey this same property. Let's manually set the registry for this particular command to ensure it tries to affect the right place. ## Related - #224 - #230
inngest-release-bot
pushed a commit
that referenced
this pull request
Jun 12, 2023
…gs (#236) ## Summary The release script in #224 and #230 almost worked. We see in run to release a `v1.x` backport that the following command failed: https://github.com/inngest/inngest-js/actions/runs/5244055017/jobs/9469531269 ``` $ npm dist-tag add inngest@2.0.1 latest npm ERR! code E401 npm ERR! 401 Unauthorized - PUT https://registry.yarnpkg.com/-/package/inngest/dist-tags/latest ``` Looks like it's defaulting to using Yarn's registry URL instsead of npm's. We get around this during publishing as we specify `publishConfig.registry` in our `package.json`, but it seems that `npm dist-tag` doesn't obey this same property. Let's manually set the registry for this particular command to ensure it tries to affect the right place. ## Related - #224 - #230 (cherry picked from commit f33464f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Releasing earlier versions to npm is a pain. This PR ensures we:
latesttag, ensuring semver updates work as expectedlatestas the version found in step 1Following this, we should be ready to support backporting and legacy releases purely with labels and PRs. 🥳
Related
latestwhen the published version is not the latest npm/npm#6778