Fix a TS error when using Inngest in projects with composite setting
#385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e9e4c60 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jpwilliams
approved these changes
Nov 7, 2023
|
Absolute star, @MonsterDeveloper 🙂 Thanks for this |
Merged
jpwilliams
pushed a commit
that referenced
this pull request
Nov 7, 2023
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## inngest@3.4.3 ### Patch Changes - [#385](#385) [`cdf02a3`](cdf02a3) Thanks [@MonsterDeveloper](https://github.com/MonsterDeveloper)! - Add exports for `InngestFunction`, `FunctionTrigger`, and `Handler` types to fix a TypeScript error when using Inngest in projects with `composite` setting in `tsconfig`. Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
|
Released in inngest@3.4.3. |
3 tasks
jpwilliams
added a commit
that referenced
this pull request
Jan 12, 2024
#460) ## Summary <!-- Succinctly describe your change, providing context, what you've changed, and why. --> This PR Adds some type exports to `index.ts` that fix a TS error in composite projects. After changes to the `types.ts` the issue #384 appeared again. This PR is similar to #385 - it fixes the TS error by adding necessary exports to the `index.ts` ## Checklist - [ ] ~~Added a [docs PR](https://github.com/inngest/website) that references this PR~~ N/A no docs needed - [ ] ~~Added unit/integration tests~~ N/A not testable - [x] Added changesets if applicable ## Related - #385 - #384 --------- Co-authored-by: Jack Williams <1736957+jpwilliams@users.noreply.github.com>
3 tasks
3 tasks
jpwilliams
added a commit
that referenced
this pull request
Feb 26, 2024
… issues (#501) ## Summary <!-- Succinctly describe your change, providing context, what you've changed, and why. --> We've seen some issues crop up when `composite: true` is present in `tsconfig.json` files. This PR adds a `composite: true` project where we test the Inngest package for compliance for the types that it exports. We purposefully want to limit the number of types exported from the main `"inngest"` entrypoint, as each type exported here becomes part of the public API, where changing those types is a breaking change. Therefore, the composite check gives us a (albeit inaccurate) test that can stop us shipping these dangerous changes. ## Checklist <!-- Tick these items off as you progress. --> <!-- If an item isn't applicable, ideally please strikeout the item by wrapping it in "~~"" and suffix it with "N/A My reason for skipping this." --> <!-- e.g. "- [ ] ~~Added tests~~ N/A Only touches docs" --> - [ ] ~Added a [docs PR](https://github.com/inngest/website) that references this PR~ N/A Bug fix and testing - [x] Added unit/integration tests - [x] Added changesets if applicable ## Related <!-- A space for any related links, issues, or PRs. --> <!-- Linear issues are autolinked. --> <!-- e.g. - INN-123 --> <!-- GitHub issues/PRs can be linked using shorthand. --> <!-- e.g. "- inngest/inngest#123" --> <!-- Feel free to remove this section if there are no applicable related links.--> - #384 - #385 - #437 - #460
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds some type exports to
index.tsthat fix a TS error incompositeprojects.Checklist
Added a docs PR that references this PRN/AAdded unit/integration testsN/ARelated
Fixes #384