Add experimental Bun example #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
djfarrelly
commented
Dec 18, 2023
examples/framework-bun/tsconfig.json
Outdated
| "lib": ["ESNext"], | ||
| "module": "esnext", | ||
| "target": "esnext", | ||
| "moduleResolution": "node", |
There was a problem hiding this comment.
By default this is "bundler" which makes all of the exports defined in the ./inngest files have this TS error:
The inferred type of 'functions' cannot be named without a reference to '../node_modules/inngest/types'. This is likely not portable. A type annotation is necessary.ts(2742)
We can have multiple suffixes for this.
jpwilliams
approved these changes
Jan 29, 2024
3 tasks
jpwilliams
added a commit
that referenced
this pull request
Feb 26, 2024
… issues (#501) ## Summary <!-- Succinctly describe your change, providing context, what you've changed, and why. --> We've seen some issues crop up when `composite: true` is present in `tsconfig.json` files. This PR adds a `composite: true` project where we test the Inngest package for compliance for the types that it exports. We purposefully want to limit the number of types exported from the main `"inngest"` entrypoint, as each type exported here becomes part of the public API, where changing those types is a breaking change. Therefore, the composite check gives us a (albeit inaccurate) test that can stop us shipping these dangerous changes. ## Checklist <!-- Tick these items off as you progress. --> <!-- If an item isn't applicable, ideally please strikeout the item by wrapping it in "~~"" and suffix it with "N/A My reason for skipping this." --> <!-- e.g. "- [ ] ~~Added tests~~ N/A Only touches docs" --> - [ ] ~Added a [docs PR](https://github.com/inngest/website) that references this PR~ N/A Bug fix and testing - [x] Added unit/integration tests - [x] Added changesets if applicable ## Related <!-- A space for any related links, issues, or PRs. --> <!-- Linear issues are autolinked. --> <!-- e.g. - INN-123 --> <!-- GitHub issues/PRs can be linked using shorthand. --> <!-- e.g. "- inngest/inngest#123" --> <!-- Feel free to remove this section if there are no applicable related links.--> - #384 - #385 - #437 - #460
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
An example using Bun and the existing
edgeserve handler.Notes
tsconfig.jsongenerated viabun initwhich can be "fixed" by changing the"moduleResolution"to"node".The inferred type of 'helloWorld' cannot be named without a reference to '../node_modules/inngest/types'. This is likely not portable. A type annotation is necessary.Checklist
Related
Bun.serve()repo and serve examples website#666