Make data.error parsing for inngest/function.failed more resilient
#476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpwilliams
added
the
⬆️ improvement
🦋 Changeset detectedLatest commit: d18c209 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jpwilliams
force-pushed
the
fix/failure-event-resilience
branch
from
b16cb31
to
d18c209
Compare
IGassmann
approved these changes
Jan 30, 2024
Merged
jpwilliams
pushed a commit
that referenced
this pull request
Jan 31, 2024
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## inngest@3.13.0 ### Minor Changes - [#475](#475) [`16f02e9`](16f02e9) Thanks [@jpwilliams](https://github.com/jpwilliams)! - Add `"inngest/bun"` serve handler for use with `Bun.serve()` ### Patch Changes - [#476](#476) [`4d52f01`](4d52f01) Thanks [@jpwilliams](https://github.com/jpwilliams)! - Make `data.error` parsing for `inngest/function.failed` more resilient - [#478](#478) [`9887ac4`](9887ac4) Thanks [@jpwilliams](https://github.com/jpwilliams)! - Remove sending `hash` when syncing - [#474](#474) [`b3a7b39`](b3a7b39) Thanks [@jpwilliams](https://github.com/jpwilliams)! - Improve UI when showing an unhandled `StepError` Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Complements inngest/inngest#1077 by also making SDK error parsing more resilient, allowing replay of these events with an updated SDK.
Checklist
Added a docs PR that references this PRN/ARelated
inngest/function.failedevents carrying incorrect error schema inngest#1077