Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sending hash when registering; not used or required #478

Merged
merged 3 commits into from
Jan 31, 2024

Conversation

jpwilliams
Copy link
Member

@jpwilliams jpwilliams commented Jan 31, 2024

Summary

Removes hash from syncs to adhere to the spec.

Checklist

  • Added a docs PR that references this PR N/A
  • Added unit/integration tests N/A
  • Added changesets if applicable

Related

@jpwilliams jpwilliams added the 💡 KTLO Chores, dependency updates, and routine tasks label Jan 31, 2024
@jpwilliams jpwilliams self-assigned this Jan 31, 2024
Copy link

changeset-bot bot commented Jan 31, 2024

🦋 Changeset detected

Latest commit: 14ae0b9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
inngest Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@inngest-release-bot inngest-release-bot added the 📦 inngest Affects the `inngest` package label Jan 31, 2024
@goodoldneon
Copy link
Contributor

Should we also delete it in the type?
https://github.com/inngest/inngest-js/blob/main/packages/inngest/src/types.ts#L1095

@jpwilliams jpwilliams merged commit 9887ac4 into main Jan 31, 2024
4 checks passed
@jpwilliams jpwilliams deleted the fix/no-register-hash branch January 31, 2024 15:05
jpwilliams pushed a commit that referenced this pull request Jan 31, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## inngest@3.13.0

### Minor Changes

- [#475](#475)
[`16f02e9`](16f02e9)
Thanks [@jpwilliams](https://github.com/jpwilliams)! - Add
`"inngest/bun"` serve handler for use with `Bun.serve()`

### Patch Changes

- [#476](#476)
[`4d52f01`](4d52f01)
Thanks [@jpwilliams](https://github.com/jpwilliams)! - Make `data.error`
parsing for `inngest/function.failed` more resilient

- [#478](#478)
[`9887ac4`](9887ac4)
Thanks [@jpwilliams](https://github.com/jpwilliams)! - Remove sending
`hash` when syncing

- [#474](#474)
[`b3a7b39`](b3a7b39)
Thanks [@jpwilliams](https://github.com/jpwilliams)! - Improve UI when
showing an unhandled `StepError`

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 inngest Affects the `inngest` package 💡 KTLO Chores, dependency updates, and routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants