Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write ExpandingLinkToPageBlock._get_child_blocks #180

Merged
merged 2 commits into from
May 28, 2024
Merged

Write ExpandingLinkToPageBlock._get_child_blocks #180

merged 2 commits into from
May 28, 2024

Conversation

sHermanGriffiths
Copy link
Contributor

Describe Your Changes

  • Add _get_child_blocks to the ExpandingLinkToPageBlock in the expandlinktopages.py plugin and implement it to patch the Client.get_child_blocks inside of the to_pandoc method. This sets the page argument to the self.page of the ExpandingLinkToPageBlock instance, making sure that the parent page of the blocks on the linked page is set to the parent page of the ExpandingLinkToPageBlock and not the linked page itself
  • Update ReadMe in preparation for the new release

How Did You Test It

N/A

@sHermanGriffiths sHermanGriffiths merged commit 7f01869 into main May 28, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@russellkan russellkan russellkan approved these changes

@yujanshrestha yujanshrestha Awaiting requested review from yujanshrestha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sHermanGriffiths @russellkan