Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement SyncedBlock #35

Merged
merged 6 commits into from
Jul 6, 2022
Merged

Implement SyncedBlock #35

merged 6 commits into from
Jul 6, 2022

Conversation

bimbashrestha
Copy link
Member

Closes #32

johndgiese
johndgiese reviewed Jul 6, 2022
View reviewed changes
tests/test_blocks.py Outdated Show resolved Hide resolved
johndgiese
johndgiese reviewed Jul 6, 2022
View reviewed changes
Copy link
Contributor

@johndgiese johndgiese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bimbashrestha nice work! I had one small change with the test. Also please add an entry to the change log in the readme; otherwise it looks good! Feel free to merge once both of these are addressed.

@bimbashrestha bimbashrestha merged commit c29636c into main Jul 6, 2022
@johndgiese johndgiese deleted the synced-block branch December 8, 2022 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johndgiese johndgiese johndgiese left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Synced Blocks
2 participants
@bimbashrestha @johndgiese