Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull in original block contents into synced block #39

Merged
merged 4 commits into from
Jul 8, 2022

Conversation

bimbashrestha
Copy link
Member

Closes #38

n2y/blocks.py Outdated Show resolved Hide resolved
n2y/blocks.py Outdated Show resolved Hide resolved
Copy link
Contributor

@johndgiese johndgiese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bimbashrestha I had a few questions. Let me know once you've addressed them all and I can do another review.

Copy link
Contributor

@johndgiese johndgiese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these changes look great! Nice work!

@bimbashrestha bimbashrestha merged commit 5d34770 into main Jul 8, 2022
@johndgiese johndgiese deleted the synced-block-cross-page-fix branch December 8, 2022 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Synced blocks not working on mermaid diagram across pages
2 participants